YARN-11536. Fix CheckStyle.

Author: slfan1989

hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/cli/RouterCLI.java

@@ -338,9 +338,10 @@ private int handlePolicy(String[] args)
          "in the FederationStateStore.");
     Option formatOpt = new Option(null, "format", true,
         "Users can specify the file format using this option. " +
-        "Currently, there are two supported file formats: XML and JSON. " +
+        "Currently, there are one supported file formats: XML." +
         "These files contain the policy information for storing queue policies.");
-    Option fileOpt = new Option(null, "file", true,
+    Option fileOpt = new Option("f", "input-file", true,
+    // TODO: 格式
         "Users can specify the file format using this option. " +
         "Currently, there are two supported file formats: XML and JSON. " +
         "These files contain the policy information for storing queue policies.");
@@ -370,24 +371,23 @@ private int handlePolicy(String[] args)
       }
       return handleSavePolicy(policy);
     }
-
     // Save Queue Policies in Batches
-    if (cliParser.hasOption(OPTION_BATCH_S) || cliParser.hasOption(OPTION_BATCH_SAVE)) {
+    else if (cliParser.hasOption(OPTION_BATCH_S) || cliParser.hasOption(OPTION_BATCH_SAVE)) {
 
       // Determine whether the file format is accurate, XML or JSON format.
       // If it is not XML or JSON, we will directly prompt the user with an error message.
       String format = null;
       if (cliParser.hasOption(OPTION_FORMAT)) {
         format = cliParser.getOptionValue(OPTION_FORMAT);
         if (StringUtils.isBlank(format) ||
-            StringUtils.equalsAnyIgnoreCase(format, FORMAT_XML, FORMAT_JSON)) {
+            !StringUtils.equalsAnyIgnoreCase(format, FORMAT_XML)) {
           System.out.println("We currently only support policy configuration files " +
-              "in XML and JSON formats.");
+              "in XML formats.");
           return EXIT_ERROR;
         }
       }
 
-      // Parse configuration file path
+      // Parse configuration file path.
       String filePath = null;
       if (cliParser.hasOption(OPTION_FILE) || cliParser.hasOption(OPTION_INPUT_FILE)) {
         filePath = cliParser.getOptionValue(OPTION_FILE);
@@ -396,9 +396,12 @@ private int handlePolicy(String[] args)
         }
       }
 
-      handBatchSavePolicies(format, filePath);
-
-      System.out.println("We need to specify the format of the input file.");
+      // Batch SavePolicies.
+      return handBatchSavePolicies(format, filePath);
+    }
+    // printUsage
+    else {
+      printUsage(args[0]);
     }
 
     return EXIT_ERROR;
@@ -507,6 +510,18 @@ protected int parseXml2Policies(String policiesXml) {
     return EXIT_ERROR;
   }
 
+  /**
+   * Parse FederationQueueWeight from the xml configuration file.
+   *
+   * We allow users to provide an xml configuration file,
+   * which stores the weight information of the queue.
+   *
+   * @param policiesXml
+   * @return
+   * @throws IOException
+   * @throws SAXException
+   * @throws ParserConfigurationException
+   */
   protected List<FederationQueueWeight> parsePoliciesByXml(String policiesXml)
       throws IOException, SAXException, ParserConfigurationException {
 
@@ -614,14 +629,13 @@ public int run(String[] args) throws Exception {
         printHelp();
       }
       return EXIT_SUCCESS;
-    }
-
-    if (CMD_DEREGISTERSUBCLUSTER.equals(cmd)) {
+    } else if (CMD_DEREGISTERSUBCLUSTER.equals(cmd)) {
       return handleDeregisterSubCluster(args);
-    }
-
-    if (CMD_POLICY.equals(cmd)) {
+    } else if (CMD_POLICY.equals(cmd)) {
       return handlePolicy(args);
+    } else {
+      System.out.println("No related commands found.");
+      printHelp();
     }
 
     return EXIT_SUCCESS;