add metrics

apache · Dec 26, 2023 · 02d21e1 · 02d21e1
1 parent 977035a
commit 02d21e1
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 1 deletion.
diff --git a/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java b/hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
@@ -3194,6 +3194,7 @@ public void run() {
              */
             if (rpcStableEnable && startTimeNanos - call.timestampNanos > rpcStableInterval) {
               call.setStable(true);
+              rpcMetrics.incrStableCalls();
             } else {
               // Re-queue the call and continue
               requeueCall(call);

diff --git a/...-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java b/...-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/metrics/RpcMetrics.java
@@ -147,6 +147,8 @@ public static RpcMetrics create(Server server, Configuration conf) {
   MutableCounterLong rpcRequeueCalls;
   @Metric("Number of successful RPC calls")
   MutableCounterLong rpcCallSuccesses;
+  @Metric("Number of stable calls")
+  MutableCounterLong rpcStableCalls;
 
   @Metric("Number of open connections") public int numOpenConnections() {
     return server.getNumOpenConnections();
@@ -363,6 +365,13 @@ public void incrRpcCallSuccesses() {
     rpcCallSuccesses.incr();
   }
 
+  /**
+   * Increments the stable calls counter.
+   */
+  public void incrStableCalls() {
+    rpcStableCalls.incr();
+  }
+
   /**
    * Returns a MutableRate Counter.
    * @return Mutable Rate
@@ -412,6 +421,15 @@ public long getRpcRequeueCalls() {
     return rpcRequeueCalls.value();
   }
 
+  /**
+   * Returns the number of stable calls.
+   * @return long
+   */
+  @VisibleForTesting
+  public long getRpcStableCalls() {
+    return rpcStableCalls.value();
+  }
+
   public MutableRate getDeferredRpcProcessingTime() {
     return deferredRpcProcessingTime;
   }

diff --git a/...hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestObserverNode.java b/...hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestObserverNode.java
@@ -63,7 +63,6 @@
 import org.apache.hadoop.hdfs.protocol.Block;
 import org.apache.hadoop.hdfs.protocol.DatanodeInfo;
 import org.apache.hadoop.hdfs.protocol.ExtendedBlock;
-import org.apache.hadoop.hdfs.protocol.HdfsFileStatus;
 import org.apache.hadoop.hdfs.protocol.LocatedBlock;
 import org.apache.hadoop.hdfs.protocol.LocatedBlocks;
 import org.apache.hadoop.hdfs.qjournal.MiniQJMHACluster;
@@ -181,6 +180,8 @@ public void testObserverRequeue() throws Exception {
   @Test
   public void testObserverStableRpc() throws Exception {
     FSNamesystem observerFsNS = dfsCluster.getNamesystem(2);
+    RpcMetrics obRpcMetrics = ((NameNodeRpcServer)dfsCluster
+        .getNameNodeRpc(2)).getClientRpcServer().getRpcMetrics();
     try {
       // Stop EditlogTailer of Observer NameNode.
       observerFsNS.getEditLogTailer().stop();
@@ -194,11 +195,13 @@ public void testObserverStableRpc() throws Exception {
       FileStatus fileStatus = dfs.getFileStatus(tmpTestPath);
       assertSentTo(0);
       assertNotNull(fileStatus);
+      assertEquals(1, obRpcMetrics.getRpcStableCalls());
 
       observerFsNS.getEditLogTailer().doTailEdits();
       fileStatus = dfs.getFileStatus(tmpTestPath);
       assertSentTo(2);
       assertNotNull(fileStatus);
+      assertEquals(1, obRpcMetrics.getRpcStableCalls());
     } finally {
       EditLogTailer editLogTailer = new EditLogTailer(observerFsNS, conf);
       observerFsNS.setEditLogTailerForTests(editLogTailer);