GUACAMOLE-2220: Support Shift/Alt/Ctrl/Meta sequences for terminal navigation and function keys. #637
Draft
bbennett-ks wants to merge 1 commit intoapache:staging/1.6.1from
Draft
Conversation
ce6b350 to
2c34445
Compare
Contributor
Author
|
I'm keeping this as a draft until I finish re-testing after a few more changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This change improves terminal keyboard interoperability by making special keys modifier-aware.
Arrows, function keys, and keypad variants now emit xterm-style modified escape sequences for Shift/Alt/Ctrl/Meta, while existing unmodified key behavior is preserved. It also cleans up key handling by replacing raw keysym literals with named constants and centralized helper logic, making behavior clearer and easier to maintain.
Detail of Changes
Testing
Use showkey -a inside SSH or Telnet session to verify output.