GUACAMOLE-2210: Add support for AAD authentication to RDP protocol.#633
Open
aleitner wants to merge 1 commit intoapache:staging/1.6.1from
Open
GUACAMOLE-2210: Add support for AAD authentication to RDP protocol.#633aleitner wants to merge 1 commit intoapache:staging/1.6.1from
aleitner wants to merge 1 commit intoapache:staging/1.6.1from
Conversation
Contributor
Author
|
Didn't realize we don't have curl. This would require adding curl as a dependency |
14d083e to
ff25596
Compare
necouchman
requested changes
Feb 14, 2026
Contributor
necouchman
left a comment
There was a problem hiding this comment.
Looks like the build is failing with an error about the switch() statement and one of the enums.
ff25596 to
de377cf
Compare
Contributor
Author
Ahh whoops! I was testing with only freerdp3 as that's when AAD support was implemented. Just added a case to the switch for freerdp2 so that it errors if AAD is selected |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AadSecuritymode#include "config.h"to source files that were missing it, fixing struct member offset mismatches.Authentication Flow
When
security=aadis set on an RDP connection:GetAccessTokencallback with the required scope and Proof-of-Possession keyguac_argvif not already configuredGatewayAvdClientIDsetting and thecommontenant endpoint$ConfigJavaScript object is parsed for session tokens (sFT,sCtx,urlPost,canary,apiCanary)GetCredentialTypeAPI is called to update server-side session state and obtain a fresh flow tokenPaired with apache/guacamole-client#1168