GUACAMOLE-1943: Add ctrl+arrows/ctrl+backspace shortcuts

[corentin-soriano]

Adds support for the following hotkeys:

• CTRL+Left arrow = move one word to the left.
• CTRL+Right arrow = move one word to the right.
• CTRL+Backspace = delete the word to the left (allow to avoid closing the tab outside of full screen mode with CTRL+w).
• CTRL+Suppr = the opposite
• Shift+Up/Down arrow = same as shift + page up/down but one line

[necouchman]

Just one request - #define things that should be constants.

[corentin-soriano]

Just one request - #define things that should be constants.

Shouldn’t I rather follow the existing style where the key/terminal codes are currently written without #define?

[necouchman]

Just one request - #define things that should be constants.

Shouldn’t I rather follow the existing style where the key/terminal codes are currently written without #define?

Well, we're trying to improve that:

https://issues.apache.org/jira/browse/GUACAMOLE-287

[corentin-soriano]

Just one request - #define things that should be constants.

Shouldn’t I rather follow the existing style where the key/terminal codes are currently written without #define?

Well, we're trying to improve that:

https://issues.apache.org/jira/browse/GUACAMOLE-287

While I was at it, I added #define constants for the entirety of the __guac_terminal_send_key function and broke up overly long lines.

Feel free to let me know if I should move the declarations to another file or if it would be better to comment each #define.

Would you prefer that I move the second commit to a new pull request?"

[necouchman]

Just one request - #define things that should be constants.

Shouldn’t I rather follow the existing style where the key/terminal codes are currently written without #define?

Well, we're trying to improve that:
https://issues.apache.org/jira/browse/GUACAMOLE-287

While I was at it, I added #define constants for the entirety of the __guac_terminal_send_key function and broke up overly long lines.

Feel free to let me know if I should move the declarations to another file or if it would be better to comment each #define.

Would you prefer that I move the second commit to a new pull request?"

Wow, thank you. I'm good with them all being in this pull request, but could you move them to a header file - guessing terminal.h?

As far as comments go, to be consistent we'll probably need a comment/documentation for each #define, but I'll let @mike-jumper or @jmuehlner add any comments they have on that...

[corentin-soriano]

Just one request - #define things that should be constants.

Shouldn’t I rather follow the existing style where the key/terminal codes are currently written without #define?

Well, we're trying to improve that:
https://issues.apache.org/jira/browse/GUACAMOLE-287

While I was at it, I added #define constants for the entirety of the __guac_terminal_send_key function and broke up overly long lines.
Feel free to let me know if I should move the declarations to another file or if it would be better to comment each #define.
Would you prefer that I move the second commit to a new pull request?"

Wow, thank you. I'm good with them all being in this pull request, but could you move them to a header file - guessing terminal.h?

As far as comments go, to be consistent we'll probably need a comment/documentation for each #define, but I'll let @mike-jumper or @jmuehlner add any comments they have on that...

#defines moved to terminal.h
If necessary, I will add a comment by #define rather than by block.

[corentin-soriano]

@jmuehlner, @mike-jumper, would you prefer that I add a comment for each #define or should I leave it like this?

[jmuehlner]

@jmuehlner, @mike-jumper, would you prefer that I add a comment for each #define or should I leave it like this?

To match our guidelines and existing style, each constant (whether defined by #define or otherwise) should have a seperate comment.

[corentin-soriano]

@jmuehlner, @mike-jumper, would you prefer that I add a comment for each #define or should I leave it like this?

To match our guidelines and existing style, each constant (whether defined by #define or otherwise) should have a seperate comment.

I added a comment for each #define and performed a rebase to update the branch.

[necouchman]

@corentin-soriano Oops, one thing - the commits should both be tagged for GUACAMOLE-1943 - even though you're tackling something in the GUACAMOLE-287 issue, it's still being done as part of this issue, so please re-tag that one commit with this Jira issue.

[corentin-soriano]

@corentin-soriano Oops, one thing - the commits should both be tagged for GUACAMOLE-1943 - even though you're tackling something in the GUACAMOLE-287 issue, it's still being done as part of this issue, so please re-tag that one commit with this Jira issue.

Done!