Skip to content

GUACAMOLE-2250: Add an option to create groups on connection import.#1197

Merged
necouchman merged 1 commit into
apache:mainfrom
eugen-keeper:guacamole-2250-create-groups-auto
Jun 24, 2026
Merged

GUACAMOLE-2250: Add an option to create groups on connection import.#1197
necouchman merged 1 commit into
apache:mainfrom
eugen-keeper:guacamole-2250-create-groups-auto

Conversation

@eugen-keeper

Copy link
Copy Markdown
Contributor

No description provided.

@eugen-keeper eugen-keeper marked this pull request as draft April 7, 2026 13:04
@eugen-keeper eugen-keeper force-pushed the guacamole-2250-create-groups-auto branch 5 times, most recently from 3941efa to 6d28ce9 Compare April 8, 2026 02:35
@eugen-keeper eugen-keeper marked this pull request as ready for review April 8, 2026 15:02
@eugen-keeper eugen-keeper marked this pull request as draft April 9, 2026 15:22
@eugen-keeper eugen-keeper marked this pull request as draft April 9, 2026 15:22
@eugen-keeper eugen-keeper force-pushed the guacamole-2250-create-groups-auto branch 3 times, most recently from 02790ff to 3985947 Compare April 9, 2026 17:18
@eugen-keeper eugen-keeper marked this pull request as ready for review April 9, 2026 17:36
Comment thread guacamole/src/main/frontend/src/app/import/services/connectionParseService.js Outdated
@eugen-keeper eugen-keeper force-pushed the guacamole-2250-create-groups-auto branch from 3985947 to c1a168d Compare June 5, 2026 14:48
@eugen-keeper eugen-keeper requested a review from bbennett-ks June 5, 2026 14:52
@eugen-keeper

Copy link
Copy Markdown
Contributor Author

apache/guacamole-manual#294

@bbennett-ks

Copy link
Copy Markdown
Contributor

I noticed 1 other thing (unrelated to this PR): the CONNECTION IMPORT screen: if no file is selected, the Cancel button is grayed out & there's no way to exit the screen. Besides selecting another menu option.

I'll file s separate issue for this as I think the fix is non-trivial.

image

@eugen-keeper eugen-keeper force-pushed the guacamole-2250-create-groups-auto branch from c1a168d to 4c5e2e1 Compare June 8, 2026 15:10
@bbennett-ks

Copy link
Copy Markdown
Contributor

I noticed 1 other thing (unrelated to this PR): the CONNECTION IMPORT screen: if no file is selected, the Cancel button is grayed out & there's no way to exit the screen. Besides selecting another menu option.

I'll file s separate issue for this as I think the fix is non-trivial.

image

https://issues.apache.org/jira/browse/GUACAMOLE-2286

@eugen-keeper eugen-keeper requested a review from bbennett-ks June 11, 2026 19:23

@necouchman necouchman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few curiosities, should be pretty much ready to go.

Comment thread guacamole/src/main/frontend/src/app/import/directives/connectionImportErrors.js Outdated
Comment thread guacamole/src/main/frontend/src/app/import/directives/connectionImportErrors.js Outdated
@eugen-keeper eugen-keeper force-pushed the guacamole-2250-create-groups-auto branch from 4c5e2e1 to 4bb85fa Compare June 22, 2026 20:09
@eugen-keeper eugen-keeper requested a review from necouchman June 22, 2026 20:37

@bbennett-ks bbennett-ks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@necouchman necouchman merged commit 9826459 into apache:main Jun 24, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants