GUACAMOLE-827: Fix BlobWriter race condition in chunk upload.#1194
Conversation
|
This MR should address this longstanding bug where subsequent chunks are sent to the BlobWriter before the previous chunk is fully processed resulting in incomplete file transfers with missing chunks. |
|
@GokulRG Thanks for submitting this. Please fix the style of the PR title and the commit message by adding a ":" after |
Of course. Thank you! |
|
Hi @necouchman, Were you able to look at this MR? |
eugen-keeper
left a comment
There was a problem hiding this comment.
I believe the fix is correct and necessary. LGTM.
@GokulRG please remove the space before the colon in the PR title and add periods at the end of the commit and PR titles.
|
@GokulRG Seems like this should be re-based against either patch or staging/1.6.1? |
|
@eugen-keeper Done. Thanks a lot for the approval. |
|
@necouchman Please let me know if it looks good now. Rebased and changed the base branch to staging/1.6.1 |
Fixes a critical race condition where multiple blob chunks could be read and sent simultaneously without proper ACK synchronization.
Changes: