GUACAMOLE-2034 : fixed a few typos, missing translation and formatting issues in french fr.json #1062
Conversation
Fixed a few typos and formatting. Harmonization with en.json file
There was a problem hiding this comment.
@YAGA29 Thank you for submitting this PR and helping out with these translations. I've noted a few specifics, but, generally:
- You don't need to add items to the translation that aren't actually being translated, as Guacamole will automatically pull from the default (English) translation.
- I'm unsure about the addition of the space before every colon (
:). As we don't do this in other translations, is there some specific reason to do it in the French translation?
Also, please re-base this PR against the apache:patch branch - the changes for 1.6.0 are already pretty well fixed, and this will not go into that release.
| "NAME" : "Apache Guacamole", | ||
| "VERSION" : "${project.version}", | ||
|
|
There was a problem hiding this comment.
Please do not put these lines in here - the translations will inherit from the default (English) translation, and this is both not required and will cause problems.
There was a problem hiding this comment.
Ok thanks, I'll delete these lines in fr.json file.
| "FIELD_HEADER_PASSWORD" : "Mot de passe : ", | ||
| "FIELD_HEADER_PASSWORD_AGAIN" : "Répéter mot de passe : ", | ||
| "FIELD_HEADER_RECORDING_WRITE_EXISTING" : "Autoriser l'écriture dans le fichier d'enregistrement existant : ", | ||
| "FIELD_HEADER_TYPESCRIPT_WRITE_EXISTING" : "Autoriser l'écriture dans le fichier TypeScript existant : ", |
There was a problem hiding this comment.
What's the reason for the additional space before the : in these translations?
There was a problem hiding this comment.
In French, the rule is to add a non-breaking space before colon and a space after colon. https://fr.wikipedia.org/wiki/Ponctuation
I don't know if we can use a nbsp in the translation file.
But that's just a small detail. Please let me know what you prefer, I can remove the space before every colon.
| "FIELD_OPTION_QUALITY_LEVEL_0" : "0", | ||
| "FIELD_OPTION_QUALITY_LEVEL_1" : "1", | ||
| "FIELD_OPTION_QUALITY_LEVEL_2" : "2", | ||
| "FIELD_OPTION_QUALITY_LEVEL_3" : "3", | ||
| "FIELD_OPTION_QUALITY_LEVEL_4" : "4", | ||
| "FIELD_OPTION_QUALITY_LEVEL_5" : "5", | ||
| "FIELD_OPTION_QUALITY_LEVEL_6" : "6", | ||
| "FIELD_OPTION_QUALITY_LEVEL_7" : "7", | ||
| "FIELD_OPTION_QUALITY_LEVEL_8" : "8", | ||
| "FIELD_OPTION_QUALITY_LEVEL_9" : "9", | ||
| "FIELD_OPTION_QUALITY_LEVEL_EMPTY" : "", | ||
|
|
There was a problem hiding this comment.
There is no need to add these to the translation file - it will inherit from the English translation, if no translation is being done.
There was a problem hiding this comment.
Ok thanks, I'll delete these lines in fr.json file.
| "FIELD_OPTION_COMPRESS_LEVEL_0" : "0", | ||
| "FIELD_OPTION_COMPRESS_LEVEL_1" : "1", | ||
| "FIELD_OPTION_COMPRESS_LEVEL_2" : "2", | ||
| "FIELD_OPTION_COMPRESS_LEVEL_3" : "3", | ||
| "FIELD_OPTION_COMPRESS_LEVEL_4" : "4", | ||
| "FIELD_OPTION_COMPRESS_LEVEL_5" : "5", | ||
| "FIELD_OPTION_COMPRESS_LEVEL_6" : "6", | ||
| "FIELD_OPTION_COMPRESS_LEVEL_7" : "7", | ||
| "FIELD_OPTION_COMPRESS_LEVEL_8" : "8", | ||
| "FIELD_OPTION_COMPRESS_LEVEL_9" : "9", | ||
| "FIELD_OPTION_COMPRESS_LEVEL_EMPTY" : "", | ||
|
|
There was a problem hiding this comment.
There is no need to add items that are not being translated.
There was a problem hiding this comment.
Ok thanks, I'll delete these lines in fr.json file.
@necouchman Thank you for your feedback. My responses below.
Ok perfect, I'll remove these items.
In French, the rule is to add a non-breaking space before colon and a space after colon. https://fr.wikipedia.org/wiki/Ponctuation I don't know if we can use a nbsp in the translation file. But that's just a small detail. Please let me know what you prefer, I can remove the space before every colon.
Ok perfect, I'll do that by the end of the week. |
If non-breaking spaces are needed, I think you will need to use Unicode characters to represent them. In Unicode, the character for a non-breaking space is U+00A0, which would be |
|
Hi Nick, I have taken into account all your comments and re-based this PR against the apache:patch branch as requested. Regards, |
Hi Mike, Sorry for not responding sooner. Thanks for your input but unfortunately Given that the rules before the colon (:) are slightly different between Swiss French, Canadian French, and French, I have used a compromise with a \u202F (Narrow No-Break Space) that displays correctly. I have corrected other typos and, as requested by Nick, re-based this PR against the apache:patch branch with the title "GUACAMOLE-2034 : Fix few typos, missing translation and formatting issue…". Regards |
|
@mike-jumper Can you re-open this one? |
|
Yep, and I'll check around for others (though if you know of 'em offhand, please ping me). The process should be just briefly recreating the |
|
@YAGA29 In addition to continuing to work through the items @mike-jumper was pointing out, this now has a conflict that must be resolved prior to merge. |
Fixed a few typos, missing translation and formatting issues in french fr.json
Harmonization with en.json file