[#708] Create binary NOTICE and LICENSE files #736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Coverage Report
|
jerryshao
reviewed
Nov 14, 2023
|
A dependency tree was generated with: To help with updating LICENSE and NOTICE in the future here is the list of all jars considered. Please note that some poms incorrectly specify their license and that multiple jars can be collapsed to a single product. |
jerryshao
approved these changes
Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add binary license and notice file and include this in the distribution. I've taken a fairly minimal approach and not included extra unneeded information. e.g not all 3rd party apache licensed software license is included as this would be a lot of duplication.
Why are the changes needed?
LICENSE and NOTICE files are required and also inform users about license conditions.
Fix: #708
Does this PR introduce any user-facing change?
No.
How was this patch tested?
(Please test your changes, and provide instructions on how to test it: