Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5950] feat(catalog-model): Add integration tests for model API #6051

Merged
merged 8 commits into from
Jan 2, 2025
Merged

[#5950] feat(catalog-model): Add integration tests for model API #6051

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9f0ccbd
Add integration tests for model API
jerryshao Dec 31, 2024
f2206b0
Address the comments
jerryshao Dec 31, 2024
c338435
Fix the bugs
jerryshao Dec 31, 2024
288c2b7
Fix the bugs
jerryshao Jan 1, 2025
33c7df4
Fix the bugs
jerryshao Jan 2, 2025
382bd11
Address the comments
jerryshao Jan 2, 2025
23e8114
Improve the style
jerryshao Jan 2, 2025
d61f077
Merge branch 'main' into issue-5950
yuqi1129 Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Improve the style
  • Loading branch information
@jerryshao
jerryshao committed Jan 2, 2025
commit 23e81149421eb9c215980492d713070ab1133b24
4 changes: 2 additions & 2 deletions ...ravitino/storage/relational/mapper/provider/base/ModelVersionAliasRelBaseSQLProvider.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,8 +103,8 @@ public String softDeleteModelVersionAliasRelsByModelIdAndAlias(
+ " mvar JOIN ("
+ " SELECT model_version FROM "
+ ModelVersionAliasRelMapper.TABLE_NAME
+ " WHERE model_id = #{modelId} AND model_version_alias = #{alias} AND deleted_at = 0"
+ ") subquery ON mvar.model_version = subquery.model_version"
+ " WHERE model_id = #{modelId} AND model_version_alias = #{alias} AND deleted_at = 0)"
+ " subquery ON mvar.model_version = subquery.model_version"
+ " SET mvar.deleted_at = (UNIX_TIMESTAMP() * 1000.0)"
+ " + EXTRACT(MICROSECOND FROM CURRENT_TIMESTAMP(3)) / 1000"
+ " WHERE mvar.model_id = #{modelId} AND mvar.deleted_at = 0";
Expand Down
Loading