Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#5901] feat(core): support tag event to Gravitino server #5998

Draft
wants to merge 14 commits into
base: main
Choose a base branch
from
Draft

[#5901] feat(core): support tag event to Gravitino server #5998

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
22bf87d
Add TagEvent
TungYuChiang Dec 24, 2024
8fdc381
Add Create & List TagEvent
TungYuChiang Dec 25, 2024
fe52536
Add all tag event
TungYuChiang Dec 25, 2024
07861b6
spotlessApply
TungYuChiang Dec 25, 2024
84a7a8d
remove redundant line
TungYuChiang Dec 26, 2024
5618df1
add unit test init for tagEvent & add createTagEvent test
TungYuChiang Dec 26, 2024
e707a47
fix createTagTest and add listTagTest
TungYuChiang Dec 26, 2024
9ff3627
add test
TungYuChiang Dec 26, 2024
1825dac
Add
TungYuChiang Jan 11, 2025
330e8e7
Add
TungYuChiang Jan 11, 2025
c8d62ec
fix bugs
TungYuChiang Jan 11, 2025
fa42784
Remove incorrect test
TungYuChiang Jan 16, 2025
2c66d22
Fix bugs of AlterTagEvent
TungYuChiang Jan 16, 2025
64a293c
ListTagEvent to ListTagsEvent & ListTagInfoEvent to ListTagsInfoEvent
TungYuChiang Jan 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove redundant line
  • Loading branch information
@TungYuChiang
TungYuChiang committed Jan 19, 2025
commit 84a7a8d67aa8a89f78190c9dba2e333e7a60dea5
2 changes: 0 additions & 2 deletions core/src/main/java/org/apache/gravitino/listener/TagEventDispatcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,6 @@ public Tag[] listTagsInfo(String metalake) {
public Tag getTag(String metalake, String name) throws NoSuchTagException {
// TODO: getTagPreEvent
try {
// TODO: getTagEvent
Tag tag = dispatcher.getTag(metalake, name);
eventBus.dispatchEvent(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please create TagInfo and passing TagInfo to GetTagEvent

new GetTagEvent(PrincipalUtils.getCurrentUserName(), metalake, name, tag));
Expand Down Expand Up @@ -149,7 +148,6 @@ public boolean deleteTag(String metalake, String name) {
public MetadataObject[] listMetadataObjectsForTag(String metalake, String name) {
// TODO: listMetadataObjectsForTagPreEvent
try {
// TODO: listMetadataObjectsForTagEvent
MetadataObject[] metadataObjects = dispatcher.listMetadataObjectsForTag(metalake, name);
eventBus.dispatchEvent(
new ListMetadataObjectsForTagEvent(
Expand Down