[#4370]feat(iceberg): support view interface for Iceberg REST server #4937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@FANNG1 please help to review, Thanks. |
FANNG1
reviewed
Sep 20, 2024
...erver/src/test/java/org/apache/gravitino/iceberg/service/rest/TestIcebergViewOperations.java
Show resolved
Hide resolved
|
@theoryxu , thanks for the PR, after supporting views, could Spark create the view in the Iceberg REST catalog? If yes, could you add corresponding integration test? |
Sure, I tested it in an internal environment and will add an integration test soon. |
|
@FANNG1 Integration tests have been added. Please review. Thanks! |
FANNG1
reviewed
Sep 27, 2024
...server/src/test/java/org/apache/gravitino/iceberg/integration/test/IcebergRESTServiceIT.java
Outdated
Show resolved
Hide resolved
|
LGTM except one comment, @theoryxu could you fix the ci error? |
FANNG1
previously approved these changes
Sep 30, 2024
FANNG1
reviewed
Sep 30, 2024
...er/src/test/java/org/apache/gravitino/iceberg/integration/test/IcebergRESTJdbcCatalogIT.java
Show resolved
Hide resolved
FANNG1
reviewed
Oct 8, 2024
FANNG1
reviewed
Oct 8, 2024
FANNG1
reviewed
Oct 8, 2024
FANNG1
approved these changes
Oct 8, 2024
FANNG1
approved these changes
Oct 8, 2024
|
@theoryxu , merged to main, thanks for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
support view interface for Iceberg REST server
Why are the changes needed?
Fix: #4370
Does this PR introduce any user-facing change?
no
How was this patch tested?