[#4882] improvement(core): Add some ut for MySQL and PostgreSQL storage backend. #4898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minor style changes.
jerryshao
approved these changes
Sep 10, 2024
|
@mchades can you please take another look? |
mchades
reviewed
Sep 11, 2024
|
Does this PR need to be backported to branch-0.6? |
mchades
approved these changes
Sep 11, 2024
|
We don't have PG support in 0.6. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add some UTs to test MySQL and PostgreSQL storage backend.
Why are the changes needed?
To improve code robustness.
Fix: #4882
Does this PR introduce any user-facing change?
N/A.
How was this patch tested?
N/A