Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[hotfix] Fix irregular variable names #4110

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

zhuangchong
Copy link
Contributor

@zhuangchong zhuangchong commented Jul 9, 2024

What changes were proposed in this pull request?

Fix irregular variable names: tablename -> tableName

Why are the changes needed?

Variable name tablename is irregular

Does this PR introduce any user-facing change?

No

How was this patch tested?

Modify variable name naming convention, no testing required.

@yuqi1129
Copy link
Contributor

yuqi1129 commented Jul 9, 2024

@zhuangchong
Thank you for your help. Please modify the PR description.
image

If you encounter any problems, please refer to the descriptions of other PRs.

@zhuangchong
Copy link
Contributor Author

@zhuangchong Thank you for your help. Please modify the PR description. image

If you encounter any problems, please refer to the descriptions of other PRs.

done.

@yuqi1129
Copy link
Contributor

yuqi1129 commented Jul 9, 2024

@zhuangchong
Can you correct all the typos tablename in the project?

@zhuangchong
Copy link
Contributor Author

zhuangchong commented Jul 9, 2024

@zhuangchong Can you correct all the typos tablename in the project?

@yuqi1129
The existing tablename is in the test class and makes sense. So there is no longer an irregularly named variable tablename.

@yuqi1129
Copy link
Contributor

yuqi1129 commented Jul 9, 2024

@zhuangchong Can you correct all the typos tablename in the project?

@yuqi1129 The existing tablename is in the test class and makes sense. So there is no longer an irregularly named variable tablename.

Okay

Copy link
Contributor

@yuqi1129 yuqi1129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuqi1129
Copy link
Contributor

yuqi1129 commented Jul 9, 2024

@zhuangchong
Thank you for your contributions.

@yuqi1129 yuqi1129 merged commit 12969b3 into apache:main Jul 9, 2024
33 checks passed
@zhuangchong zhuangchong deleted the code-var-rename branch July 9, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants