Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#3058] improvement(client-python): Correct type specification of create_fileset function #3509

Merged
merged 1 commit into from
May 23, 2024

Conversation

noidname01
Copy link
Collaborator

What changes were proposed in this pull request?

  • Change the suggest type of type from Catalog.Type to Fileset.Type

Why are the changes needed?

Fix: #3508

Does this PR introduce any user-facing change?

No

How was this patch tested?

./gradlew :clients:client-python:test

@jerryshao
Copy link
Contributor

@noidname01 can you please add a UT for this?

@noidname01
Copy link
Collaborator Author

noidname01 commented May 23, 2024

@jerryshao Sure, I think it's better to work on it after #3517 has been done. I will solve that issue first.

Copy link
Member

@xunliu xunliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noidname01 Thank you fix this issue.

@@ -92,7 +92,7 @@ def create_fileset(
self,
ident: NameIdentifier,
comment: str,
type: Catalog.Type,
type: Fileset.Type,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xunliu xunliu changed the title [#3058] improvement(client-python): Correct type specification of create_fileset function in fileset_catalog.py [#3058] improvement(client-python): Correct type specification of create_fileset function May 23, 2024
@jerryshao jerryshao merged commit ee6b9db into apache:main May 23, 2024
9 checks passed
github-actions bot pushed a commit that referenced this pull request May 23, 2024
…ate_fileset function (#3509)

### What changes were proposed in this pull request?

* Change the suggest type of `type` from `Catalog.Type` to
`Fileset.Type`

### Why are the changes needed?

Fix: #3508 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

`./gradlew :clients:client-python:test`

Co-authored-by: TimWang <tim.wang@pranaq.com>
diqiu50 pushed a commit to diqiu50/gravitino that referenced this pull request Jun 13, 2024
…of create_fileset function (apache#3509)

### What changes were proposed in this pull request?

* Change the suggest type of `type` from `Catalog.Type` to
`Fileset.Type`

### Why are the changes needed?

Fix: apache#3508 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

`./gradlew :clients:client-python:test`

Co-authored-by: TimWang <tim.wang@pranaq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Correct type specification of create_fileset function in fileset_catalog.py
3 participants