[#3058] improvement(client-python): Correct type specification of create_fileset function #3509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@noidname01 can you please add a UT for this? |
|
@jerryshao Sure, I think it's better to work on it after #3517 has been done. I will solve that issue first. |
xunliu
approved these changes
May 23, 2024
| @@ -92,7 +92,7 @@ def create_fileset( | |||
| self, | |||
| ident: NameIdentifier, | |||
| comment: str, | |||
| type: Catalog.Type, | |||
| type: Fileset.Type, | |||
There was a problem hiding this comment.
Yes, you are right.
The corresponding java code in the here: https://github.com/datastrato/gravitino/blob/main/api/src/main/java/com/datastrato/gravitino/file/FilesetCatalog.java#L76
xunliu
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
May 23, 2024
…ate_fileset function (#3509) ### What changes were proposed in this pull request? * Change the suggest type of `type` from `Catalog.Type` to `Fileset.Type` ### Why are the changes needed? Fix: #3508 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? `./gradlew :clients:client-python:test` Co-authored-by: TimWang <tim.wang@pranaq.com>
diqiu50
pushed a commit
to diqiu50/gravitino
that referenced
this pull request
Jun 13, 2024
…of create_fileset function (apache#3509) ### What changes were proposed in this pull request? * Change the suggest type of `type` from `Catalog.Type` to `Fileset.Type` ### Why are the changes needed? Fix: apache#3508 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? `./gradlew :clients:client-python:test` Co-authored-by: TimWang <tim.wang@pranaq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
typefromCatalog.TypetoFileset.TypeWhy are the changes needed?
Fix: #3508
Does this PR introduce any user-facing change?
No
How was this patch tested?
./gradlew :clients:client-python:test