-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#2927] Improvement(catalog-lakehouse-iceberg): Support more file formats in using clause when create iceberg tables #2931
Conversation
…le formats in using clause when create iceberg tables
…le formats in using clause when create iceberg tables
Hi @FANNG1 could you help review this PR when you are free? Thanks |
...e-iceberg/src/main/java/com/datastrato/gravitino/catalog/lakehouse/iceberg/IcebergTable.java
Outdated
Show resolved
Hide resolved
...va/com/datastrato/gravitino/catalog/lakehouse/iceberg/integration/test/CatalogIcebergIT.java
Outdated
Show resolved
Hide resolved
all comments have been addressed. |
...va/com/datastrato/gravitino/catalog/lakehouse/iceberg/integration/test/CatalogIcebergIT.java
Outdated
Show resolved
Hide resolved
LGTM, except one minor comment |
new comments have been addressed. |
After another thought, seems we forgot to consider the alter table properties action. I'm not sure whether it works for changing Iceberg table provider, could you add |
ok, i will do this. |
updated. and added test code. |
@caican00 merged to main, thanks for your work |
What changes were proposed in this pull request?
Support more file formats in using clause when create iceberg tables, such as
using parquet
,using orc
,using avro
,using iceberg
.using other provider will throw an exception.
Why are the changes needed?
Because Iceberg official supports using parquet/orc/avro/iceberg when create a new table.
Fix: #2927
Does this PR introduce any user-facing change?
Yes, users can using
parquet/orc/avro/iceberg
keywork inusing clause
when create a new table.How was this patch tested?
New IT.