[#2921] fix(catalog-lakehouse-iceberg): Add width param to bucket and truncate functions in Gravitino SortOrder #2928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…et and truncate functions in Gravitino SortOrder
…et and truncate functions in Gravitino SortOrder
…to iceberg-properties
…le formats in using clause when create iceberg tables
…le formats in using clause when create iceberg tables
caican00
commented
Apr 15, 2024
...in/java/com/datastrato/gravitino/catalog/lakehouse/iceberg/converter/ToIcebergSortOrder.java
Show resolved
Hide resolved
|
Hi @FANNG1 could you help review this PR when you are free? Thanks |
caican00
commented
Apr 15, 2024
api/src/main/java/com/datastrato/gravitino/rel/expressions/FunctionExpression.java
Outdated
Show resolved
Hide resolved
…to iceberg-properties
… into iceberg-properties
|
Hi @FANNG1 do you have time to review this PR? thanks |
|
Hi @Clearvive could you help review this PR? Thank you |
|
@caican00 , sorry for the delay, this PR is related to API which we should check it carefully. |
|
gently ping @Clearvive, could you help review this PR when you are free? Thank you |
@caican00 , Clearvive if not focused on Gravitino now |
got it, thank you @FANNG1 |
|
Hi @yuqi1129 could you help review this pr if you are free? Thank you. |
|
@FANNG1 could you please help review this PR? Thank you! |
ok |
FANNG1
reviewed
May 21, 2024
...in/java/com/datastrato/gravitino/catalog/lakehouse/iceberg/converter/ToIcebergSortOrder.java
Show resolved
Hide resolved
FANNG1
reviewed
May 21, 2024
...ava/com/datastrato/gravitino/catalog/lakehouse/iceberg/converter/TestToIcebergSortOrder.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
May 21, 2024
...eberg/src/test/java/com/datastrato/gravitino/catalog/lakehouse/iceberg/TestIcebergTable.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
May 21, 2024
...om/datastrato/gravitino/catalog/lakehouse/iceberg/integration/test/CatalogIcebergBaseIT.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
May 22, 2024
.../test/java/com/datastrato/gravitino/catalog/lakehouse/iceberg/converter/TestBaseConvert.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
May 22, 2024
.../test/java/com/datastrato/gravitino/catalog/lakehouse/iceberg/converter/TestBaseConvert.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
May 22, 2024
.../test/java/com/datastrato/gravitino/catalog/lakehouse/iceberg/converter/TestBaseConvert.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
May 22, 2024
...a/com/datastrato/gravitino/catalog/lakehouse/iceberg/converter/TestFromIcebergSortOrder.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
May 22, 2024
.../test/java/com/datastrato/gravitino/catalog/lakehouse/iceberg/converter/TestBaseConvert.java
Outdated
Show resolved
Hide resolved
FANNG1
reviewed
May 22, 2024
...om/datastrato/gravitino/catalog/lakehouse/iceberg/integration/test/CatalogIcebergBaseIT.java
Outdated
Show resolved
Hide resolved
|
LGTM except the comment, @mchades do you have time to review again? |
caican00
force-pushed
the
iceberg-properties
branch
from
ace6cae
to
28dfe4b
Compare
|
@FANNG1 all comments have been addressed, could you help review again? Thanks! |
FANNG1
approved these changes
May 22, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 22, 2024
… truncate functions in Gravitino SortOrder (#2928) ### What changes were proposed in this pull request? Add width param to bucket and truncate functions in Gravitino SortOrder. for example: change `bucket([id]) `to `bucket(10, id)` change `truncate([name]) `to `truncate(2, name)` ### Why are the changes needed? SortOrder in Iceberg supports `FunctionExpression`, such as `year, month, bucket, truncate, etc`. `truncate` and `bucket` functions both have two parameters, such as `bucket(10, col1), truncate(2, col2)`. However, in gravitino, when converting an iceberg sortorder with `bucket` or `truncate` to gravitino sortOrder, there is only one parameter in `bucket` and `truncate` functions. This picture shows the details of the parameters of the `bucket` and `truncate` functions in gravitino sortorder, we can test it in `com.datastrato.gravitino.catalog.lakehouse.iceberg.converter.TestFromIcebergSortOrder#testFromSortOrder`  And if we want to convert the gravitino sortOrder with `bucket` or `truncate` to iceberg sortOrder, we will get the following error as the first param is missing. ``` java.lang.IllegalArgumentException: Bucket sort should have 2 arguments at com.google.common.base.Preconditions.checkArgument(Preconditions.java:143) at com.datastrato.gravitino.catalog.lakehouse.iceberg.converter.ToIcebergSortOrder.toSortOrder(ToIcebergSortOrder.java:56) at com.datastrato.gravitino.catalog.lakehouse.iceberg.converter.TestFromIcebergSortOrder.testFromSortOrder(TestFromIcebergSortOrder.java:86) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:725) at org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60) ``` Fix: #2921 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? New UTs and ITs.
caican00
added a commit
to caican00/gravitino
that referenced
this pull request
May 23, 2024
…et and truncate functions in Gravitino SortOrder (apache#2928) Add width param to bucket and truncate functions in Gravitino SortOrder. for example: change `bucket([id]) `to `bucket(10, id)` change `truncate([name]) `to `truncate(2, name)` SortOrder in Iceberg supports `FunctionExpression`, such as `year, month, bucket, truncate, etc`. `truncate` and `bucket` functions both have two parameters, such as `bucket(10, col1), truncate(2, col2)`. However, in gravitino, when converting an iceberg sortorder with `bucket` or `truncate` to gravitino sortOrder, there is only one parameter in `bucket` and `truncate` functions. This picture shows the details of the parameters of the `bucket` and `truncate` functions in gravitino sortorder, we can test it in `com.datastrato.gravitino.catalog.lakehouse.iceberg.converter.TestFromIcebergSortOrder#testFromSortOrder`  And if we want to convert the gravitino sortOrder with `bucket` or `truncate` to iceberg sortOrder, we will get the following error as the first param is missing. ``` java.lang.IllegalArgumentException: Bucket sort should have 2 arguments at com.google.common.base.Preconditions.checkArgument(Preconditions.java:143) at com.datastrato.gravitino.catalog.lakehouse.iceberg.converter.ToIcebergSortOrder.toSortOrder(ToIcebergSortOrder.java:56) at com.datastrato.gravitino.catalog.lakehouse.iceberg.converter.TestFromIcebergSortOrder.testFromSortOrder(TestFromIcebergSortOrder.java:86) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:725) at org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60) ``` Fix: apache#2921 No New UTs and ITs.
diqiu50
pushed a commit
to diqiu50/gravitino
that referenced
this pull request
Jun 13, 2024
…et and truncate functions in Gravitino SortOrder (apache#2928) ### What changes were proposed in this pull request? Add width param to bucket and truncate functions in Gravitino SortOrder. for example: change `bucket([id]) `to `bucket(10, id)` change `truncate([name]) `to `truncate(2, name)` ### Why are the changes needed? SortOrder in Iceberg supports `FunctionExpression`, such as `year, month, bucket, truncate, etc`. `truncate` and `bucket` functions both have two parameters, such as `bucket(10, col1), truncate(2, col2)`. However, in gravitino, when converting an iceberg sortorder with `bucket` or `truncate` to gravitino sortOrder, there is only one parameter in `bucket` and `truncate` functions. This picture shows the details of the parameters of the `bucket` and `truncate` functions in gravitino sortorder, we can test it in `com.datastrato.gravitino.catalog.lakehouse.iceberg.converter.TestFromIcebergSortOrder#testFromSortOrder`  And if we want to convert the gravitino sortOrder with `bucket` or `truncate` to iceberg sortOrder, we will get the following error as the first param is missing. ``` java.lang.IllegalArgumentException: Bucket sort should have 2 arguments at com.google.common.base.Preconditions.checkArgument(Preconditions.java:143) at com.datastrato.gravitino.catalog.lakehouse.iceberg.converter.ToIcebergSortOrder.toSortOrder(ToIcebergSortOrder.java:56) at com.datastrato.gravitino.catalog.lakehouse.iceberg.converter.TestFromIcebergSortOrder.testFromSortOrder(TestFromIcebergSortOrder.java:86) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:498) at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:725) at org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60) ``` Fix: apache#2921 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? New UTs and ITs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add width param to bucket and truncate functions in Gravitino SortOrder.
for example:
change
bucket([id])tobucket(10, id)change
truncate([name])totruncate(2, name)Why are the changes needed?
SortOrder in Iceberg supports
FunctionExpression, such asyear, month, bucket, truncate, etc.truncateandbucketfunctions both have two parameters, such asbucket(10, col1), truncate(2, col2).However, in gravitino, when converting an iceberg sortorder with
bucketortruncateto gravitino sortOrder, there is only one parameter inbucketandtruncatefunctions.This picture shows the details of the parameters of the
bucketandtruncatefunctions in gravitino sortorder, we can test it incom.datastrato.gravitino.catalog.lakehouse.iceberg.converter.TestFromIcebergSortOrder#testFromSortOrderAnd if we want to convert the gravitino sortOrder with
bucketortruncateto iceberg sortOrder, we will get the following error as the first param is missing.Fix: #2921
Does this PR introduce any user-facing change?
No
How was this patch tested?
New UTs and ITs.