Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2618] fix(doc): Remove description field in fileset openapi doc #2619

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

jerryshao
Copy link
Contributor

What changes were proposed in this pull request?

Remove the "description" field in Fileset related APIs.

Why are the changes needed?

Because the description field does not exist in the related APIs, it should be removed, otherwise, it will lead to an issue.

Fix: #2618

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Manually verification.

@jerryshao jerryshao requested a review from mchades March 20, 2024 16:23
@jerryshao jerryshao self-assigned this Mar 20, 2024
@jerryshao
Copy link
Contributor Author

@coolderli would you please help to review? Thanks.

@jerryshao jerryshao closed this Mar 20, 2024
@jerryshao jerryshao reopened this Mar 20, 2024
@coolderli
Copy link
Collaborator

@jerryshao LGTM. My fault. How did you discover this issue?Do you have any testing processes based on OpenAPI documentation?

@jerryshao
Copy link
Contributor Author

@coolderli we're building the fileset UI, based on this yml file generated APIs we do some tests and find the issue.

@coolderli
Copy link
Collaborator

@coolderli we're building the fileset UI, based on this yml file generated APIs we do some tests and find the issue.

@jerryshao Thanks. Got it.

Copy link
Contributor

@mchades mchades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mchades mchades merged commit e1b4b18 into apache:main Mar 21, 2024
14 of 20 checks passed
coolderli pushed a commit to coolderli/gravitino that referenced this pull request Apr 2, 2024
…oc (apache#2619)

### What changes were proposed in this pull request?

Remove the "description" field in Fileset related APIs.

### Why are the changes needed?

Because the `description` field does not exist in the related APIs, it
should be removed, otherwise, it will lead to an issue.

Fix: apache#2618 

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Manually verification.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug report] fileset API is not correct in openapi.yml
3 participants