Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MINOR] feat(ci): add integration-test/metastore_db to .gitignore #2529

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

zhoukangcn
Copy link
Contributor

What changes were proposed in this pull request?

add integration-test/metastore_db to .gitignore

Why are the changes needed?

Avoid temporary files being tracked by Git after IT testing.

Does this PR introduce any user-facing change?

N/A

How was this patch tested?

local

@yuqi1129
Copy link
Contributor

@zhoukangcn
Can you also change the build script and remove it when executing gradle :integration-test:clean?

@zhoukangcn
Copy link
Contributor Author

zhoukangcn commented Mar 14, 2024

already exsits in integration-test/build.gradle.kts

https://github.com/datastrato/gravitino/blob/ca1714eb5cc87692e99f54b7540cd62f41884b22/integration-test/build.gradle.kts#L186

tasks.clean {
  delete("metastore_db")
  delete("target")
  delete("derby.log")
}

Copy link
Contributor

@yuqi1129 yuqi1129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuqi1129 yuqi1129 merged commit 6dbfbc5 into apache:main Mar 14, 2024
5 checks passed
yijhenlin pushed a commit to yijhenlin/gravitino that referenced this pull request Mar 14, 2024
…ache#2529)

### What changes were proposed in this pull request?

add integration-test/metastore_db to .gitignore

### Why are the changes needed?

Avoid temporary files being tracked by Git after IT testing.

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

local
@zhoukangcn zhoukangcn deleted the minor branch April 16, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants