Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#2401] improvement(spark-connector): support alter namespace operation #2407

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

SteNicholas
Copy link
Member

@SteNicholas SteNicholas commented Mar 1, 2024

What changes were proposed in this pull request?

Support alter namespace operation implementation.

Why are the changes needed?

Support to set namespace properties in Spark sql like:

ALTER DATABASE inventory SET DBPROPERTIES ('Edited-by' = 'John', 'Edit-date' = '01/01/2001');

Fix: #2401

Does this PR introduce any user-facing change?

No.

How was this patch tested?

  • SparkIT#testAlterSchema

@SteNicholas
Copy link
Member Author

cc @FANNG1.

@FANNG1
Copy link
Contributor

FANNG1 commented Mar 1, 2024

@SteNicholas thanks for your work, could you add related sql test in SparkIT? please refer to https://spark.apache.org/docs/latest/sql-ref-syntax-ddl-alter-database.html

@qqqttt123
Copy link
Contributor

qqqttt123 commented Mar 1, 2024

@SteNicholas Hi, maybe @PengleiShi is doing this issue, too. This issue has been assigned to him before your pull request.

@SteNicholas
Copy link
Member Author

@FANNG1, I have added SparkIT#testAlterSchema to verify the alter namespace operation. PTAL.

@SteNicholas
Copy link
Member Author

@FANNG1, I have addressed above comments. PTAL.

@FANNG1
Copy link
Contributor

FANNG1 commented Mar 5, 2024

LGTM except one comment

@FANNG1
Copy link
Contributor

FANNG1 commented Mar 5, 2024

@SteNicholas could you change the Spark SQL keyword to upper case? since #2437 is merged first.

@SteNicholas
Copy link
Member Author

@FANNG1, I will update this pull request tonight and change the Spark SQL keyword to upper case.

@SteNicholas
Copy link
Member Author

@FANNG1, I have addressed above comment and changed Spark SQL keyword to upper case. PTAL.

@SteNicholas SteNicholas requested a review from FANNG1 March 6, 2024 06:38
@FANNG1
Copy link
Contributor

FANNG1 commented Mar 6, 2024

@FANNG1, I have addressed above comment and changed Spark SQL keyword to upper case. PTAL.

some minor comments, could you fix it?

@SteNicholas SteNicholas requested a review from FANNG1 March 6, 2024 08:02
@FANNG1 FANNG1 merged commit 26911d1 into apache:main Mar 6, 2024
12 checks passed
@FANNG1
Copy link
Contributor

FANNG1 commented Mar 6, 2024

merged to main, @SteNicholas thanks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] spark-connector support alter namespace operation.
3 participants