Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1955] imporvement(core): Fix resource leak in RocksDBKvBackend.java #2138

Merged
merged 1 commit into from
Feb 17, 2024

Conversation

coolderli
Copy link
Collaborator

What changes were proposed in this pull request?

close #1955

Why are the changes needed?

(Please clarify why the changes are needed. For instance,

  1. If you propose a new API, clarify the use case for a new API.
  2. If you fix a bug, describe the bug.)

Fix: #1955

Does this PR introduce any user-facing change?

  • no

How was this patch tested?

  • unit

@yuqi1129
Copy link
Contributor

yuqi1129 commented Feb 7, 2024

Overall, I'm okay with the changes. @coolderli Can you update the PR description to make it more standardized?

@justinmclean justinmclean changed the title [#1955] improvement(core): Fix resource leak in RocksDBKvBackend.java [#1955] Fix resource leak in RocksDBKvBackend.java Feb 12, 2024
@justinmclean justinmclean self-requested a review February 12, 2024 23:57
Copy link
Member

@justinmclean justinmclean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for your contribution!

@coolderli coolderli changed the title [#1955] Fix resource leak in RocksDBKvBackend.java [#1955] imporvement(core): Fix resource leak in RocksDBKvBackend.java Feb 16, 2024
@coolderli
Copy link
Collaborator Author

Overall, I'm okay with the changes. @coolderli Can you update the PR description to make it more standardized?

I have updated the PR description. Please take a look. Thanks.

Copy link
Contributor

@yuqi1129 yuqi1129 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuqi1129 yuqi1129 merged commit b11a32f into apache:main Feb 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Possible resource leak in RocksDBKvBackend.java
3 participants