[#2035] fix(trino-connector): Fix type conversion about type varhcar and char for PG catalog
#2056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuqi1129
added
need backport
|
@diqiu50 please help to review this. |
diqiu50
reviewed
Feb 5, 2024
| @@ -5,6 +5,35 @@ CREATE TABLE "test.gt_postgresql".gt_db1.tb01 ( | |||
| salary int | |||
| ); | |||
|
|
|||
There was a problem hiding this comment.
Can we move the varchar test to a new file?
| ); | ||
|
|
||
| show create table "test.gt_postgresql".gt_db1.tb04; | ||
|
|
There was a problem hiding this comment.
We discussed this issue before In Trino, and the conclusion should be..
varchar ==> string
varchar(n) ==> varchar(n) if n > limit string
char == char (char(1)）
char(n) = char(n) if n > limit throw exception
|
@jerryshao |
yuqi1129
removed
need backport
OK. |
|
No need any more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove logic that convert
varcharandcharto typestring.Why are the changes needed?
Type conversion should be aligned with their definition.
Fix: #2035
Does this PR introduce any user-facing change?
N/A.
How was this patch tested?
new IT cases in
trino-ci-testset