-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1530] feat(spark-connector): support specifying scala version to build and test Gravitino #1582
Conversation
Could you provide different profiles for different version scala referring to the solution of Spark? |
I planed to do it latter on #1574 after spark-connector is almost ready, because this will introduce complex, maybe we should avoid it in the initial stage. |
@jerryshao , please help to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Another issue is to ensure compatible issue. It seems that there is no compatible issue. |
sorry there is a mistake, |
support specify scala versions, by two methods:
@qqqttt123 please help to review again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @FANNG1
thanks @qqqttt123 for your advise |
… to build and test Gravitino (apache#1582) ### What changes were proposed in this pull request? support specify scala versions, by two methods: 1. `gradle build -PscalaVersion=xx` 2. set `defaultScalaVersion` in gradle.properties method2 will be overwrite by method1 if both existing, and supports scala 2.12 for now. ### Why are the changes needed? spark hive connector just supports scala 2.12 Fix: apache#1530 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? existing UTs
… to build and test Gravitino (apache#1582) ### What changes were proposed in this pull request? support specify scala versions, by two methods: 1. `gradle build -PscalaVersion=xx` 2. set `defaultScalaVersion` in gradle.properties method2 will be overwrite by method1 if both existing, and supports scala 2.12 for now. ### Why are the changes needed? spark hive connector just supports scala 2.12 Fix: apache#1530 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? existing UTs
What changes were proposed in this pull request?
support specify scala versions, by two methods:
gradle build -PscalaVersion=xx
defaultScalaVersion
in gradle.propertiesmethod2 will be overwrite by method1 if both existing,
and supports scala 2.12 for now.
Why are the changes needed?
spark hive connector just supports scala 2.12
Fix: #1530
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing UTs