-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#1469] improvement(doc): Add doc about webUI operation #1270
Conversation
toc_max_heading_level: 5 | ||
license: 'Copyright 2023 Datastrato Pvt Ltd. This software is licensed under the Apache License version 2.' | ||
--- | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a simple paragraph to introduce the content of this doc in a general view?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please add a simple paragraph to introduce the content of this doc in a general view?
DONE
docs/webui.md
Outdated
gravitino.authenticator = simple | ||
``` | ||
|
||
If the configuration parameter for `gravitino.authenticator` is set to `simple`, the webUI will directly display the homepage (Metalakes). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't use the future tense, just using the simple tense: the web UI directly displays the homepage...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't use the future tense, just using the simple tense: the web UI directly displays the homepage...
DONE
docs/webui.md
Outdated
|
||
## Initial page | ||
|
||
The webUI homepage displaying in Gravitino depends on the configuration parameter for OAuth mode, see the details in [Security](security.md). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
web UI, not webUI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
web UI, not webUI.
DONE
docs/webui.md
Outdated
|
||
![metalake-actions](assets/webui/metalake-actions.png) | ||
|
||
#### 1. Show metalake details |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can remove this "1. ", "2. ", "3. " here and below.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you can remove this "1. ", "2. ", "3. " here and below.
DONE
docs/webui.md
Outdated
|
||
> Required properties in various providers | ||
|
||
- hive |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capitalize the first letter for Hive, Iceberg, etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capitalize the first letter for Hive, Iceberg, etc.
DONE
docs/webui.md
Outdated
|
||
- hive | ||
|
||
Following: [Apache Hive catalog](apache-hive-catalog) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow the Hive catalog doc...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow the Hive catalog doc...
DONE
|
||
### Schema | ||
|
||
Under Construction... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'd better have a basic list view and detailed view for schema and table.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it would be better you also have screenshots to show the schemas and tables.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor things to correct.
docs/webui.md
Outdated
gravitino.authenticator = oauth | ||
``` | ||
|
||
If the configuration parameter for `gravitino.authenticator` is set to `oauth`, the web UI will directly display the login page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will display is better but we need to avoid using will
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use active voice
7e30d03
to
f676ad4
Compare
I have revised the entire content according to the suggestions. Please check it again. Thank you very much! |
docs/webui.md
Outdated
gravitino.authenticator = simple | ||
``` | ||
|
||
Set the configuration parameter for `gravitino.authenticator` to `simple`, the web UI directly displays the homepage (Metalakes). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no need for "directly"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DONE
docs/webui.md
Outdated
|
||
![webui-metalakes-simple](assets/webui/metalakes-simple.png) | ||
|
||
At the top-right, displays the current version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the top-right, the UI displays the current Gravitino version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DONE
docs/webui.md
Outdated
|
||
Clicking on a metalake name in the table views catalogs in a metalake. | ||
|
||
If this is the first time, it shows no data until after creating catalog. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
creating a catalog.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DONE
docs/webui.md
Outdated
More features are under development. For detailed capabilities, please refer to the [Manage metadata using Gravitino](manage-metadata-using-gravitino.md) document. | ||
::: | ||
|
||
[Build](how-to-build#quick-start) and [deploy](getting-started#getting-started-locally) the Gravitino Web UI and open it in a browser at [http://localhost:8090](http://localhost:8090). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The url is not always "http://localhost:8090", it depends on how users configure gravitino host and port, I can think you can write to
open it in a browser at `http://<gravitino-host>:<gravitino-port>`, by default is [http://localhost:8090](http://localhost:8090).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DONE
docs/webui.md
Outdated
|
||
![webui-login-with-oauth](assets/webui/login-with-oauth.png) | ||
|
||
1. Enter the values corresponding to your specific configuration. For detailed instructions, please refer to [Security](security). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[Security](security.md)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DONE
docs/webui.md
Outdated
import Tabs from '@theme/Tabs' | ||
import TabItem from '@theme/TabItem' | ||
|
||
This document primarily outlines how users can manage metadata within Gravitino using the web UI, the graphical interface accessible through a web browser as an alterative to writing code or using the REST interface. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"the graphical interface is accessible..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DONE
docs/webui.md
Outdated
Currently, you can integrate [OAuth settings](security.md) to view, add, modify, and delete metalakes, create catalogs, and view catalogs, schemas, and tables, among other functions. | ||
|
||
:::caution | ||
More features are under development. For detailed capabilities, please refer to the [Manage metadata using Gravitino](manage-metadata-using-gravitino.md) document. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"For the details, please..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DONE
docs/webui.md
Outdated
More features are under development. For detailed capabilities, please refer to the [Manage metadata using Gravitino](manage-metadata-using-gravitino.md) document. | ||
::: | ||
|
||
[Build](how-to-build#quick-start) and [deploy](getting-started#getting-started-locally) the Gravitino Web UI and open it in a browser at `http://<gravitino-host>:<gravitino-port>`, by default is [http://localhost:8090](http://localhost:8090). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add ".md" suffix to all the links here and below, like "how-to-build.md#quick-start"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DONE
docs/webui.md
Outdated
gravitino.authenticator = simple | ||
``` | ||
|
||
Set the configuration parameter for `gravitino.authenticator` to `simple`, the web UI displays the homepage (Metalakes). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove "for".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DONE
docs/webui.md
Outdated
gravitino.authenticator = oauth | ||
``` | ||
|
||
Set the configuration parameter for `gravitino.authenticator` to `oauth`, the web UI directly displays the login page. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also here remove "for". And remove "directly" here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DONE
745cc56
to
3d761cf
Compare
docs/webui.md
Outdated
3. **Provider**(**_required_**): `hive`/`iceberg`/`mysql`/`postgresql` | ||
4. **Comment**(_optional_): the comment of this catalog | ||
5. **Properties**(**specific provider inculdes required fileds**) | ||
5. **Properties**(**specific provider included required fields**) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ch3yne what's the meaning of this sentence, I cannot follow it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
each `provider` must fill in the required property fields specifically.
### What changes were proposed in this pull request? Compose documentation for the webUI, detailing the procedures for CRUD operations. ### Why are the changes needed? Fix: #1269 ### Does this PR introduce _any_ user-facing change? N/A ### How was this patch tested? N/A
What changes were proposed in this pull request?
Compose documentation for the webUI, detailing the procedures for CRUD operations.
Why are the changes needed?
Fix: #1269
Does this PR introduce any user-facing change?
N/A
How was this patch tested?
N/A