[#1253] bugfix(jdbc): fix jdbc catalog store empty audit info issue #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clearvive
force-pushed
the
1253/add-jdbc-id
branch
from
3ed9e35
to
c8c2aad
Compare
|
Will this pull request back port to branch 0.3? |
I have added a label |
|
@qqqttt123 please help to review. |
qqqttt123
previously approved these changes
Dec 26, 2023
qqqttt123
reviewed
Dec 26, 2023
| @@ -276,7 +276,7 @@ public Table loadTable(NameIdentifier tableIdent) throws NoSuchTableException { | |||
| } | |||
| Map<String, String> properties = | |||
| load.properties() == null ? Maps.newHashMap() : Maps.newHashMap(load.properties()); | |||
| StringIdentifier.addToProperties(id, properties); | |||
| properties = StringIdentifier.addToProperties(id, properties); | |||
There was a problem hiding this comment.
Could you rename addToProperties to a more proper name?
qqqttt123
approved these changes
Dec 26, 2023
jerryshao
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Dec 26, 2023
…1257) ### What changes were proposed in this pull request? Mysql&Postgres catalog store empty audit info fix. ### Why are the changes needed? Fix: #1253 ### Does this PR introduce _any_ user-facing change? Users will receive audit information ### How was this patch tested? IT --------- Co-authored-by: Clearvive <clearvive@datastrato.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Mysql&Postgres catalog store empty audit info fix.
Why are the changes needed?
Fix: #1253
Does this PR introduce any user-facing change?
Users will receive audit information
How was this patch tested?
IT