[#121] feat(storage): Implement RocksDB storage backend for EntityStore #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xunliu
changed the title
|
@jerryshao @justinmclean Can you take time to review this PR ? |
jerryshao
reviewed
Jul 27, 2023
core/src/main/java/com/datastrato/graviton/EntityStoreFactory.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/graviton/EntityStoreFactory.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/graviton/EntityStoreFactory.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/graviton/storage/kv/KvEntityStore.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/graviton/storage/kv/KvEntityStore.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/graviton/storage/kv/KvEntityStore.java
Outdated
Show resolved
Hide resolved
jerryshao
reviewed
Jul 28, 2023
core/src/main/java/com/datastrato/graviton/storage/kv/KvEntityStore.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/graviton/storage/kv/KvEntityStore.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/graviton/storage/kv/RocksDBKvBackend.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/graviton/storage/kv/RocksDBKvBackend.java
Show resolved
Hide resolved
core/src/main/java/com/datastrato/graviton/storage/kv/RocksDBKvBackend.java
Show resolved
Hide resolved
jerryshao
reviewed
Jul 31, 2023
core/src/main/java/com/datastrato/graviton/storage/kv/RocksDBKvBackend.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/graviton/storage/kv/RocksDBKvBackend.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/datastrato/graviton/storage/kv/RocksDBKvBackend.java
Show resolved
Hide resolved
|
All comments has been resolved, please review again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Please outline the changes and how this PR fixes the issue.)
Why are the changes needed?
Issue #122 has introduced the KvBackend storage interface for entity storing, but till now, No implementation has been made to implement this interface. this PR accomplishes KV backend for RocksDB
Fix: #121
Does this PR introduce any user-facing change?
No
How was this patch tested?
Add UT
TestEntityStorageBackend