Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#1112] fix(jdbc): deleteColumn throws exception for table with ifExisting = true. #1230

Conversation

github-actions[bot]
Copy link

What changes were proposed in this pull request?

When 'ifExisting' is set to true in the 'deleteColumn' function, it will validate the existence of the specified column. If the column does not exist, it will throw an exception.

Why are the changes needed?

Fix: #1112

Does this PR introduce any user-facing change?

Users should be aware that when using 'deleteColumn,' it may throw a new exception, 'IllegalArgumentException.'

How was this patch tested?

UT

…sting = true. (#1200)

### What changes were proposed in this pull request?
When 'ifExisting' is set to true in the 'deleteColumn' function, it will
validate the existence of the specified column. If the column does not
exist, it will throw an exception.


### Why are the changes needed?
Fix: #1112 

### Does this PR introduce _any_ user-facing change?
Users should be aware that when using 'deleteColumn,' it may throw a new
exception, 'IllegalArgumentException.'

### How was this patch tested?
UT

---------

Co-authored-by: Clearvive <clearvive@datastrato.com>
@github-actions github-actions bot added cherry-pick need backport Issues that need to backport to another branch labels Dec 21, 2023
@jerryshao jerryshao closed this Dec 21, 2023
@jerryshao jerryshao reopened this Dec 21, 2023
Copy link
Author

Code Coverage Report

Overall Project 66.02% -0.03% 🟢
Files changed 0% 🔴

Module Coverage
catalog-jdbc-common 39.31% -1.13% 🔴
Files
Module File Coverage
catalog-jdbc-common JdbcTableOperations.java 75% -4.75% 🔴

@jerryshao jerryshao merged commit 631b579 into branch-0.3 Dec 21, 2023
4 checks passed
@qqqttt123 qqqttt123 deleted the cherry-pick-branch-0.3-972747e772e11a9e889887ae7980b3a79e4919a9 branch December 26, 2023 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick need backport Issues that need to backport to another branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants