Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Group supports list operations #4873

Closed
jerqi opened this issue Sep 6, 2024 · 1 comment · Fixed by #4879
Closed

[Improvement] Group supports list operations #4873

jerqi opened this issue Sep 6, 2024 · 1 comment · Fixed by #4879
Assignees
@jerqi @LiuQhahah
Labels
0.6.1 Release v0.6.1 0.7.0 Release v0.7.0 improvement Improvements on everything

Comments

@jerqi
Copy link
Collaborator

jerqi commented Sep 6, 2024

What would you like to be improved?

We need to know all the group informations. We don't support to list groups operation.

How should we improve?

We need to know all the group informations. We don't support to list groups operation.
@jerqi jerqi added the improvement Improvements on everything label Sep 6, 2024
@LiuQhahah
Copy link
Contributor

Hi @jerqi

From the code (

gravitino/server/src/main/java/org/apache/gravitino/server/web/rest/GroupOperations.java

Line 49 in c7200c8

@Path("/metalakes/{metalake}/groups")
), we can find that the level is metalake, so I want to know whether the all of " all the group information" means the metalake level instead of the root level?

LiuQhahah added a commit to LiuQhahah/gravitino that referenced this issue Sep 8, 2024
@LiuQhahah
apache#4873 support list group
10070c1
@LiuQhahah LiuQhahah mentioned this issue Sep 8, 2024
Merged
LiuQhahah added a commit to LiuQhahah/gravitino that referenced this issue Sep 26, 2024
@LiuQhahah
Merge remote-tracking branch 'origin/main' into apache#4873-Improveme…
7f2f3c9 
…nt-Group-supports-list-operations
LiuQhahah added a commit to LiuQhahah/gravitino that referenced this issue Sep 26, 2024
@LiuQhahah
apache#4873 support list group
eb8cba6
LiuQhahah added a commit to LiuQhahah/gravitino that referenced this issue Sep 26, 2024
@LiuQhahah
Merge branch 'main' into apache#4873-Improvement-Group-supports-list-…
936fd17 
…operations

# Conflicts:
#	clients/client-java/src/test/java/org/apache/gravitino/client/TestUserGroup.java
#	core/src/main/java/org/apache/gravitino/authorization/UserGroupManager.java
#	core/src/main/java/org/apache/gravitino/storage/relational/JDBCBackend.java
LiuQhahah added a commit to LiuQhahah/gravitino that referenced this issue Sep 26, 2024
@LiuQhahah
apache#4873 support list group
3614812
LiuQhahah added a commit to LiuQhahah/gravitino that referenced this issue Sep 26, 2024
@LiuQhahah
Merge branch 'main' into apache#4873-Improvement-Group-supports-list-…
779671e 
…operations

# Conflicts:
#	core/src/main/java/org/apache/gravitino/storage/relational/JDBCBackend.java
LiuQhahah added a commit to LiuQhahah/gravitino that referenced this issue Sep 26, 2024
@LiuQhahah
apache#4873 support list group format
4e14f9d
LiuQhahah added a commit to LiuQhahah/gravitino that referenced this issue Sep 26, 2024
@LiuQhahah
apache#4873 support list group : format
a0206a9
LiuQhahah added a commit to LiuQhahah/gravitino that referenced this issue Sep 26, 2024
@LiuQhahah
apache#4873 support list group : format
95034a3
LiuQhahah added a commit to LiuQhahah/gravitino that referenced this issue Sep 26, 2024
@LiuQhahah
apache#4873 support list group
ed9cc9d
LiuQhahah added a commit to LiuQhahah/gravitino that referenced this issue Sep 26, 2024
@LiuQhahah
apache#4873 support list group add javaDoc
2e24f4b
jerqi added a commit to LiuQhahah/gravitino that referenced this issue Sep 27, 2024
@jerqi
Merge remote-tracking branch 'upstream/main' into apache#4873-Improve…
e5dcd17 
…ment-Group-supports-list-operations
@jerryshao jerryshao added 0.6.1 Release v0.6.1 0.7.0 Release v0.7.0 labels Sep 27, 2024
jerqi added a commit to qqqttt123/gravitino that referenced this issue Sep 27, 2024
@LiuQhahah @jerqi
[apache#4873] feat(core): support list group (apache#4879)
ec0a340 
support list group

support list group

Fix: apache#4873

no

UT

---------

Co-authored-by: Rory <roryqi@apache.org>
@jerqi jerqi mentioned this issue Sep 27, 2024
Merged
jerryshao pushed a commit that referenced this issue Sep 27, 2024
@jerqi @LiuQhahah
[#4873] feat(core,server): Supports to list group (#4879) (#5036)
1d43f49 
### What changes were proposed in this pull request?
Supports to list groups.

### Why are the changes needed?

Fix: #4873 

### Does this PR introduce _any_ user-facing change?
I will add the document later.

### How was this patch tested?
UT.

Co-authored-by: Qiang-Liu <liuqiang9596@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jerqi jerqi

@LiuQhahah LiuQhahah

Labels
0.6.1 Release v0.6.1 0.7.0 Release v0.7.0 improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#4873] feat(core): support list group LiuQhahah/gravitino
3 participants
@jerryshao @jerqi @LiuQhahah