Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Subtask] Fix missing-timeout Pylint rule for client-python #3765

Open
noidname01 opened this issue Jun 4, 2024 · 4 comments
Open

[Subtask] Fix missing-timeout Pylint rule for client-python #3765

noidname01 opened this issue Jun 4, 2024 · 4 comments
Labels
good first issue Good for newcomers subtask Subtasks of umbrella issue

Comments

@noidname01
Copy link
Collaborator

Describe the subtask

  • Define a reasonable timeout for request.get to prevent program from hanging indefinitely

Parent issue

#3560
@noidname01 noidname01 added the subtask Subtasks of umbrella issue label Jun 4, 2024
@noidname01 noidname01 mentioned this issue Jun 4, 2024
Open
10 tasks
@xunliu xunliu added the good first issue Good for newcomers label Jun 4, 2024
@adheeshsharma19
Copy link

Hi, can I work on this ?
Also, which file under client-python requires timeout to be added.

@noidname01
Copy link
Collaborator Author

@adheeshsharma19 Sure, you're welcome.😊
It's in tests/integration/integration_test_env.py, actually you can remove missing-timeout from disable section in pylintrc and run ./gradlew clients:client-python:pylint, it should log where the problem is.

adheeshsharma19 added a commit to adheeshsharma19/gravitino that referenced this issue Jun 5, 2024
@adheeshsharma19
Fixed missing-timeout Pylint rule for client-python apache#3765
cc02878 
Fixed missing-timeout Pylint rule for client-python apache#3765 and removed
missing-timeout from disable section in pylintrc as well.
@adheeshsharma19
Copy link

Thanks

@adheeshsharma19 adheeshsharma19 mentioned this issue Jun 6, 2024
Open
@adheeshsharma19
Copy link

Have raised a PR :#3810

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers subtask Subtasks of umbrella issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@xunliu @noidname01 @adheeshsharma19