Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Subtask] Fix redefined-builtin Pylint rule for client-python #3561

Closed
noidname01 opened this issue May 25, 2024 · 0 comments · Fixed by #3562
Closed

[Subtask] Fix redefined-builtin Pylint rule for client-python #3561

noidname01 opened this issue May 25, 2024 · 0 comments · Fixed by #3562
Assignees
@noidname01
Labels
0.5.1 Release v0.5.1 0.6.0 Release v0.6.0 subtask Subtasks of umbrella issue

Comments

@noidname01
Copy link
Collaborator

noidname01 commented May 25, 2024 •
edited
Loading

Describe the subtask

Fix redefined-builtin to replace Python bultin functions and keywords with other variable names.

Parent issue

#3560
@noidname01 noidname01 added the subtask Subtasks of umbrella issue label May 25, 2024
This was referenced May 25, 2024
Open
Merged
jerryshao pushed a commit that referenced this issue May 27, 2024
@noidname01
[#3561] improvement(client-python): Fix redefined-builtin Pylint rule…
6cc6602 
… for client-python (#3562)

### What changes were proposed in this pull request?

* Replace varaible names `type` and `property`, which is Python
functions and keywords, with more readable and custom variable names

### Why are the changes needed?

Fix: #3561 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

`./gradlew clients:client-python:test`

---------

Co-authored-by: TimWang <tim.wang@pranaq.com>
github-actions bot pushed a commit that referenced this issue May 27, 2024
@noidname01 @web-flow
[#3561] improvement(client-python): Fix redefined-builtin Pylint rule…
3a3ac6b 
… for client-python (#3562)

### What changes were proposed in this pull request?

* Replace varaible names `type` and `property`, which is Python
functions and keywords, with more readable and custom variable names

### Why are the changes needed?

Fix: #3561 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

`./gradlew clients:client-python:test`

---------

Co-authored-by: TimWang <tim.wang@pranaq.com>
@jerryshao jerryshao mentioned this issue May 27, 2024
Merged
@jerryshao jerryshao added 0.5.1 Release v0.5.1 0.6.0 Release v0.6.0 labels May 27, 2024
yuqi1129 pushed a commit that referenced this issue May 27, 2024
@jerryshao @noidname01
[#3561] improvement(client-python): Fix redefined-builtin Pylint rule…
0fa0401 
… for client-python (#3568)

<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
   Examples:
     - "[#123] feat(operator): support xxx"
     - "[#233] fix: check null before access result in xxx"
     - "[MINOR] refactor: fix typo in variable name"
     - "[MINOR] docs: fix typo in README"
     - "[#255] test: fix flaky test NameOfTheTest"
   Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. If the PR is unfinished, please mark this PR as draft.
-->

### What changes were proposed in this pull request?

* Replace varaible names `type` and `property`, which is Python
functions and keywords, with more readable and custom variable names

### Why are the changes needed?

Fix: #3561 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

`./gradlew clients:client-python:test`

Co-authored-by: noidname01 <55401762+noidname01@users.noreply.github.com>
Co-authored-by: TimWang <tim.wang@pranaq.com>
diqiu50 pushed a commit to diqiu50/gravitino that referenced this issue Jun 13, 2024
@noidname01 @diqiu50
[apache#3561] improvement(client-python): Fix redefined-builtin Pylin…
b08037f 
…t rule for client-python (apache#3562)

### What changes were proposed in this pull request?

* Replace varaible names `type` and `property`, which is Python
functions and keywords, with more readable and custom variable names

### Why are the changes needed?

Fix: apache#3561 

### Does this PR introduce _any_ user-facing change?

No

### How was this patch tested?

`./gradlew clients:client-python:test`

---------

Co-authored-by: TimWang <tim.wang@pranaq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@noidname01 noidname01

Labels
0.5.1 Release v0.5.1 0.6.0 Release v0.6.0 subtask Subtasks of umbrella issue
Projects
None yet
Milestone
No milestone
2 participants
@jerryshao @noidname01