Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] File with incorrect header / missing LICENSE information #2801

Closed
justinmclean opened this issue Apr 4, 2024 · 4 comments · Fixed by #2868
Closed

[Improvement] File with incorrect header / missing LICENSE information #2801

justinmclean opened this issue Apr 4, 2024 · 4 comments · Fixed by #2868
Assignees
Labels
improvement Improvements on everything

Comments

@justinmclean
Copy link
Member

What would you like to be improved?

This file seems to be a 3rd party file from https://github.com/confluentinc/kafka-streams-examples

/catalogs/catalog-messaging-kafka/src/test/java/com/datastrato/gravitino/catalog/kafka/embeddedKafka/KafkaEmbedded.java

How should we improve?

Restore header to file and add file name and LICENSE information to LICENSE. As this repo has a NOTICE file it also needs to be mentioned in NOTICE. https://github.com/confluentinc/kafka-streams-examples/blob/master/NOTICE

@justinmclean
Copy link
Member Author

@mchades Can you please confirm if this is the case?

@mchades
Copy link
Contributor

mchades commented Apr 8, 2024

Mainly from this, could you please help me confirm if there are any license issues with this project?

@justinmclean
Copy link
Member Author

Yes, we need to know where it originally came from (note the Copyright Confluent Inc.) and if it had a NOTICE file. It needs to be added to the LICENSE files and NOTICE file if the original had a NOTICE file.

@justinmclean
Copy link
Member Author

The original header needs to be replaced, as someone else is the copyright owner.

jerryshao pushed a commit that referenced this issue Apr 12, 2024
…ka source code (#2868)

### What changes were proposed in this pull request?

fix incorrect LICENSE information of Kafka source code

### Why are the changes needed?

Fix: #2800 #2801 

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

no need
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improvements on everything
Projects
None yet
3 participants