You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
please add related code to com.datastrato.gravitino.spark.catalogGravitinoCatalog.java, transfrom Spark TableChange to Gravitino TableChange, you could refer to #2502 , Hive doesn't support update column nullable for now, so no need to add integrate test. public Table alterTable(Identifier ident, TableChange... changes) throws NoSuchTableException { }
Hi I would like to work on this! However, could you elaborate on
Hive doesn't support update column nullable for now, so no need to add integrate test.
What I understand now is that I probably should add testAlterTableUpdateColumnNullability() in SparkCommonIT.java like the referenced PR did, alongside with converting spark TableChange.UpdateColumnNullavility() and adding its unit test. Did I miss anything? Thanks!
@ichuniq , you needn't add testAlterTableUpdateColumnNullability() in SparkCommonIT.java, because it wouldn't work. you only need to implement convert logic and add unit test.
…erTable for spark connector (#2699)
### What changes were proposed in this pull request?
Add support for `UpdateColumnNullability` when transforming spark's
TableChange to Gravatino's TableChange for spark connector
### Why are the changes needed?
Fix: #2649
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
New unit test & run
`./gradlew :spark-connector:test`
Describe the subtask
please add related code to
com.datastrato.gravitino.spark.catalogGravitinoCatalog.java
, transfrom Spark TableChange to Gravitino TableChange, you could refer to #2502 , Hive doesn't support update column nullable for now, so no need to add integrate test.public Table alterTable(Identifier ident, TableChange... changes) throws NoSuchTableException { }
Parent issue
#1227
The text was updated successfully, but these errors were encountered: