Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Do not expose TableDTO directly to the Gravitino client #2628

Closed
mchades opened this issue Mar 21, 2024 · 0 comments · Fixed by #2630
Closed

[Improvement] Do not expose TableDTO directly to the Gravitino client #2628

mchades opened this issue Mar 21, 2024 · 0 comments · Fixed by #2630
Assignees
@mchades
Labels
improvement Improvements on everything
Milestone
Gravitino 0.5.0

Comments

@mchades
Copy link
Contributor

mchades commented Mar 21, 2024

What would you like to be improved?

TableDTO is used for JSON data transmission, we should not use it directly in the Gravitino clientthe

How should we improve?

cast tableDTO to Table before usage
@mchades mchades added the improvement Improvements on everything label Mar 21, 2024
@mchades mchades self-assigned this Mar 21, 2024
@mchades mchades added this to the Gravitino 0.5.0 milestone Mar 21, 2024
@mchades mchades mentioned this issue Mar 21, 2024
Merged
FANNG1 pushed a commit that referenced this issue Mar 22, 2024
@mchades
[#2628] improvement(client): remove tableDTO in client (#2630)
aa54de7 
### What changes were proposed in this pull request?

- remove TableDTO in the client
- convert TableDTO to Table in the client

### Why are the changes needed?

Fix: #2628 

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

existing tests
coolderli pushed a commit to coolderli/gravitino that referenced this issue Apr 2, 2024
@mchades
[apache#2628] improvement(client): remove tableDTO in client (apache#…
db01f8c 
…2630)

### What changes were proposed in this pull request?

- remove TableDTO in the client
- convert TableDTO to Table in the client

### Why are the changes needed?

Fix: apache#2628 

### Does this PR introduce _any_ user-facing change?

no

### How was this patch tested?

existing tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mchades mchades

Labels
improvement Improvements on everything
Projects
None yet
Milestone
Gravitino 0.5.0
Development

Successfully merging a pull request may close this issue.

[#2628] improvement(client): remove tableDTO in client mchades/gravitino
1 participant
@mchades