Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Subtask] support update column comment for spark-connector #2449

Closed
FANNG1 opened this issue Mar 7, 2024 · 2 comments · Fixed by #2524
Closed

[Subtask] support update column comment for spark-connector #2449

FANNG1 opened this issue Mar 7, 2024 · 2 comments · Fixed by #2524
Assignees
@Yangxuhao123
Labels
good first issue Good for newcomers subtask Subtasks of umbrella issue
Milestone
Gravitino 0.5.0

Comments

@FANNG1
Copy link
Contributor

FANNG1 commented Mar 7, 2024

Describe the subtask

Describe the subtask

please add related code to com.datastrato.gravitino.spark.catalogGravitinoCatalog.java, transfrom Spark TableChange to Gravitino TableChange, you could refer to renameTable implement

  public Table alterTable(Identifier ident, TableChange... changes) throws NoSuchTableException {
    throw new NotSupportedException("Doesn't support altering table for now");
  }

Related Spark SQL should add to SparkIT.java, please refer https://spark.apache.org/docs/latest/sql-ref-syntax-ddl-alter-table.html

Parent issue

#1227
@FANNG1 FANNG1 added subtask Subtasks of umbrella issue good first issue Good for newcomers labels Mar 7, 2024
@Yangxuhao123
Copy link
Contributor

@FANNG1 i will work on this issue.

@jerryshao jerryshao added this to the Gravitino 0.5.0 milestone Mar 7, 2024
@FANNG1
Copy link
Contributor Author

FANNG1 commented Mar 7, 2024 •
edited
Loading

@Yangxuhao123 thanks for taking this issue, please contact me if have any problems

Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 13, 2024
apache#2449 update column comment
e6403c4
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 13, 2024
apache#2449 format code
059742c
@FANNG1 FANNG1 mentioned this issue Mar 13, 2024
Merged
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 13, 2024
apache#2449 fix unit test bug
a81441c
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 13, 2024
apache#2449 format code
2693de6
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 14, 2024
apache#2449 update assertEquals to assertArrayEquals
10cc8f3
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 14, 2024
apache#2449 format code
ed46c3e
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 14, 2024
[apache#2449] update column comment
3d68d7d
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 14, 2024
apache#2449 fix unit test bug
a8aa499
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 14, 2024
apache#2449 fix unit test bug
aef28a7
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 14, 2024
[apache#2449] update column comment
4771fff
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 14, 2024
[apache#2449] update column comment
a7d9de1
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 14, 2024
apache#2449 format code
40c4bc6
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 14, 2024
apache#2449 format code
779afcd
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 14, 2024
[apache#2449] format code
40f8f59
FANNG1 pushed a commit that referenced this issue Mar 14, 2024
@Yangxuhao123
[#2449] feat(spark-connector): support update column comment for spar…
8c58d67 
…k-connector (#2524)

### What changes were proposed in this pull request?

support update column comment for spark-connector

### Why are the changes needed?

Fix: #2449

### Does this PR introduce _any_ user-facing change?

`alter table default_catalog.default_db.default_table change column col1
col1 int comment 'new_comment;'`

### How was this patch tested?

write new unit tests.

---------

Co-authored-by: ryan02.yang <ryan02.yang@vipshop.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yangxuhao123 Yangxuhao123

Labels
good first issue Good for newcomers subtask Subtasks of umbrella issue
Projects
None yet
Milestone
Gravitino 0.5.0
3 participants
@jerryshao @FANNG1 @Yangxuhao123