Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Subtask] support update column comment for spark-connector #2449

Closed
FANNG1 opened this issue Mar 7, 2024 · 2 comments · Fixed by #2524
Closed

[Subtask] support update column comment for spark-connector #2449

FANNG1 opened this issue Mar 7, 2024 · 2 comments · Fixed by #2524
Assignees
Labels
good first issue Good for newcomers subtask Subtasks of umbrella issue

Comments

@FANNG1
Copy link
Contributor

FANNG1 commented Mar 7, 2024

Describe the subtask

Describe the subtask

please add related code to com.datastrato.gravitino.spark.catalogGravitinoCatalog.java, transfrom Spark TableChange to Gravitino TableChange, you could refer to renameTable implement

  public Table alterTable(Identifier ident, TableChange... changes) throws NoSuchTableException {
    throw new NotSupportedException("Doesn't support altering table for now");
  }

Related Spark SQL should add to SparkIT.java, please refer https://spark.apache.org/docs/latest/sql-ref-syntax-ddl-alter-table.html

Parent issue

#1227

@FANNG1 FANNG1 added subtask Subtasks of umbrella issue good first issue Good for newcomers labels Mar 7, 2024
@Yangxuhao123
Copy link
Contributor

@FANNG1 i will work on this issue.

@FANNG1
Copy link
Contributor Author

FANNG1 commented Mar 7, 2024

@Yangxuhao123 thanks for taking this issue, please contact me if have any problems

Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 13, 2024
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 13, 2024
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 13, 2024
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 13, 2024
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 14, 2024
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 14, 2024
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 14, 2024
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 14, 2024
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 14, 2024
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 14, 2024
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 14, 2024
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 14, 2024
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 14, 2024
Yangxuhao123 pushed a commit to Yangxuhao123/gravitino that referenced this issue Mar 14, 2024
FANNG1 pushed a commit that referenced this issue Mar 14, 2024
…k-connector (#2524)

### What changes were proposed in this pull request?

support update column comment for spark-connector

### Why are the changes needed?

Fix: #2449

### Does this PR introduce _any_ user-facing change?

`alter table default_catalog.default_db.default_table change column col1
col1 int comment 'new_comment;'`

### How was this patch tested?

write new unit tests.

---------

Co-authored-by: ryan02.yang <ryan02.yang@vipshop.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers subtask Subtasks of umbrella issue
Projects
None yet
3 participants