Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EPIC] Improve Trino and Gravitino char/varchar mapping. #2356

Closed
3 tasks done
yuqi1129 opened this issue Feb 26, 2024 · 1 comment
Closed
3 tasks done

[EPIC] Improve Trino and Gravitino char/varchar mapping. #2356

yuqi1129 opened this issue Feb 26, 2024 · 1 comment
Labels
epic Key feature

Comments

@yuqi1129
Copy link
Contributor

yuqi1129 commented Feb 26, 2024 •
edited
Loading

Describe the proposal

There exists type mapping issues for data type varchar/type between Gravitino and Trino, we need to refine it. for more please see
#2035
https://docs.google.com/document/d/1xNkl4Y2t8Bfb8UOOdGBhyQr5DDreAOLmK8FOWiIDiQM/edit

Task list
@yuqi1129 yuqi1129 added the epic Key feature label Feb 26, 2024
@yuqi1129 yuqi1129 mentioned this issue Feb 26, 2024
Merged
yuqi1129 added a commit that referenced this issue Mar 11, 2024
@yuqi1129
[#2357] improvement(trino): Fix varchar type mapping between Gravitin…
77fcc13 
…o JDBC catalog and Trino (#2358)

### What changes were proposed in this pull request?

Modify the type mapping for VARCHAR and CHAR to match Gravitino and
Trino.

### Why are the changes needed?

please see issue #2356

Fix: #2035
Fix: #2357

### Does this PR introduce _any_ user-facing change?

N/A. 

### How was this patch tested?

New UTs.
@yuqi1129
Copy link
Contributor Author

I will close it as all subtasks have been completed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
epic Key feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yuqi1129