Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Filtering empty keys when create or update in the web UI #1428

Closed
ch3yne opened this issue Jan 10, 2024 · 0 comments · Fixed by #1412
Closed

[Improvement] Filtering empty keys when create or update in the web UI #1428

ch3yne opened this issue Jan 10, 2024 · 0 comments · Fixed by #1412
Assignees
@ch3yne
Labels
improvement Improvements on everything

Comments

@ch3yne
Copy link
Contributor

ch3yne commented Jan 10, 2024

What would you like to be improved?

Filtering empty keys when operating create or update.

How should we improve?

Remove empty keys' properties before submitting.
@ch3yne ch3yne added the improvement Improvements on everything label Jan 10, 2024
@ch3yne ch3yne self-assigned this Jan 10, 2024
@ch3yne ch3yne mentioned this issue Jan 10, 2024
Merged
jerryshao pushed a commit that referenced this issue Jan 10, 2024
@ch3yne
[#1428] improvement(UI): Filtering empty keys when create or update (#…
fbd19c8 
…1412)

### What changes were proposed in this pull request?

Filtering empty keys when operating create or update.

<img width="480" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/c2bbf850-dfe9-4419-9f6d-6d9cd2fbe0f1">

After adding an empty key, the API will prompt an error message, so we
need to prevent this from happening at the frontend level.

### Why are the changes needed?

Fix: #1428 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

N/A
github-actions bot pushed a commit that referenced this issue Jan 10, 2024
@ch3yne @web-flow
[#1428] improvement(UI): Filtering empty keys when create or update (#…
20cfba9 
…1412)

### What changes were proposed in this pull request?

Filtering empty keys when operating create or update.

<img width="480" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/c2bbf850-dfe9-4419-9f6d-6d9cd2fbe0f1">

After adding an empty key, the API will prompt an error message, so we
need to prevent this from happening at the frontend level.

### Why are the changes needed?

Fix: #1428 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

N/A
@jerryshao jerryshao mentioned this issue Jan 10, 2024
Merged
mchades pushed a commit that referenced this issue Jan 10, 2024
@jerryshao @ch3yne
[#1428] improvement(UI): Filtering empty keys when create or update (#…
cad1f33 
…1430)

### What changes were proposed in this pull request?

Filtering empty keys when operating create or update.

<img width="480" alt="image"
src="https://github.com/datastrato/gravitino/assets/17310559/c2bbf850-dfe9-4419-9f6d-6d9cd2fbe0f1">

After adding an empty key, the API will prompt an error message, so we
need to prevent this from happening at the frontend level.

### Why are the changes needed?

Fix: #1428 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

N/A

Co-authored-by: CHEYNE <contact@ch3yne.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ch3yne ch3yne

Labels
improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#1428] improvement(UI): Filtering empty keys when create or update ch3yne/gravitino
1 participant
@ch3yne