Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug report] Support Fixed type conversion Gravitino and Trino #1317

Closed
yuqi1129 opened this issue Jan 3, 2024 · 0 comments · Fixed by #1318
Closed

[Bug report] Support Fixed type conversion Gravitino and Trino #1317

yuqi1129 opened this issue Jan 3, 2024 · 0 comments · Fixed by #1318
Assignees
@yuqi1129

Comments

@yuqi1129
Copy link
Contributor

yuqi1129 commented Jan 3, 2024

Describe what's wrong

  1. create a iceberg in Gravitino
curl -X POST -H "Content-Type: application/json" -d '{"name":"iceberg_t1","comment":"my test table","columns":[{"name":"id","type":"integer","comment":"id column comment","nullable":false},{"name":"name","type":"fixed(10)","comment":"name column comment","nullable":false}],"properties":{"format-version":"1"}}' http://localhost:8090/api/metalakes/test/catalogs/iceberg_catalog/schemas/db2/tables
  1. show the table in Trino
trino:db2> show create table iceberg_t1\G
Query 20240103_144846_00005_ejx62 failed: Unsupported gravitino datatype: com.datastrato.gravitino.rel.types.Types$FixedType@29
trino:db2>

Error message and/or stacktrace

trino:db2> show create table iceberg_t1\G
Query 20240103_144846_00005_ejx62 failed: Unsupported gravitino datatype: com.datastrato.gravitino.rel.types.Types$FixedType@29

trino:db2>

How to reproduce

Do as they do.

Additional context

No response
@yuqi1129 yuqi1129 self-assigned this Jan 3, 2024
@yuqi1129 yuqi1129 mentioned this issue Jan 4, 2024
Merged
jerryshao pushed a commit that referenced this issue Jan 8, 2024
@yuqi1129
[#1317] fix(trino-connector): Support Fixed type conversion (#1318)
6544417 
### What changes were proposed in this pull request?

1. Suppoort type 'Fixed' in Trino connector `GeneralDataTypeTransformer`
 
### Why are the changes needed?

Fixed type is needed by Iceberg type.

Fix: #1317 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

IT.
github-actions bot pushed a commit that referenced this issue Jan 8, 2024
@yuqi1129 @web-flow
[#1317] fix(trino-connector): Support Fixed type conversion (#1318)
2a029dd 
### What changes were proposed in this pull request?

1. Suppoort type 'Fixed' in Trino connector `GeneralDataTypeTransformer`
 
### Why are the changes needed?

Fixed type is needed by Iceberg type.

Fix: #1317 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

IT.
@jerryshao jerryshao mentioned this issue Jan 8, 2024
Merged
jerryshao added a commit that referenced this issue Jan 8, 2024
@jerryshao @yuqi1129
[#1317] fix(trino-connector): Support Fixed type conversion (#1376)
2b37f70 
### What changes were proposed in this pull request?

1. Suppoort type 'Fixed' in Trino connector `GeneralDataTypeTransformer`
 
### Why are the changes needed?

Fixed type is needed by Iceberg type.

Fix: #1317 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

IT.

Co-authored-by: Qi Yu <yuqi@datastrato.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuqi1129 yuqi1129

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#1317] fix(trino-connector): Support Fixed type conversion yuqi1129/gravitino
1 participant
@yuqi1129