Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Files missing headers and license #1267

Closed
Tracked by #1335
justinmclean opened this issue Dec 27, 2023 · 3 comments · Fixed by #1353
Closed
Tracked by #1335

[Improvement] Files missing headers and license #1267

justinmclean opened this issue Dec 27, 2023 · 3 comments · Fixed by #1353
Assignees
@brandboat
Labels
good first issue Good for newcomers improvement Improvements on everything

Comments

@justinmclean
Copy link
Member

justinmclean commented Dec 27, 2023 •
edited
Loading

What would you like to be improved?

These files don't have a header so people don't know how they are licensed or if they are 3rd party code:
./integration-test/src/test/java/com/datastrato/gravitino/integration/test/catalog/jdbc/mysql/service/MysqlService.java
./integration-test/src/test/java/com/datastrato/gravitino/integration/test/catalog/jdbc/postgresql/service/PostgreSqlService.java

I thought the rat plugin would catch this?

How should we improve?

Add correct headers to files
@justinmclean justinmclean added the improvement Improvements on everything label Dec 27, 2023
@jerryshao jerryshao removed their assignment Dec 27, 2023
@jerryshao jerryshao added the good first issue Good for newcomers label Dec 27, 2023
@qqqttt123 qqqttt123 mentioned this issue Jan 5, 2024
Closed
12 tasks
@brandboat
Copy link
Member

May I take over this issue ? Many Thanks !

@yuqi1129
Copy link
Contributor

yuqi1129 commented Jan 5, 2024

May I take over this issue ? Many Thanks !

Sure， please go ahead.

@brandboat brandboat mentioned this issue Jan 5, 2024
Merged
@qqqttt123
Copy link
Contributor

May I take over this issue ? Many Thanks !

Assigned. Thanks @brandboat

qqqttt123 pushed a commit that referenced this issue Jan 7, 2024
@brandboat
[#1267] fix: Add missing headers and license (#1353)
986efd9 
### What changes were proposed in this pull request?
add missing headers and license

### Why are the changes needed?
Fix: #1267

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
N/A (no code change, only add missing license)
github-actions bot pushed a commit that referenced this issue Jan 7, 2024
@brandboat @web-flow
[#1267] fix: Add missing headers and license (#1353)
24c6e0c 
### What changes were proposed in this pull request?
add missing headers and license

### Why are the changes needed?
Fix: #1267

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
N/A (no code change, only add missing license)
@jerryshao jerryshao mentioned this issue Jan 7, 2024
Merged
qqqttt123 pushed a commit that referenced this issue Jan 7, 2024
@jerryshao @brandboat
[#1267] fix: Add missing headers and license (#1360)
00e5ebb 
### What changes were proposed in this pull request?
add missing headers and license

### Why are the changes needed?
Fix: #1267

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
N/A (no code change, only add missing license)

Co-authored-by: Kuan-Po Tseng <brandboat@gmail.com>
diqiu50 pushed a commit to diqiu50/gravitino that referenced this issue Jan 8, 2024
@brandboat @diqiu50
[apache#1267] fix: Add missing headers and license (apache#1353)
ebb64cc 
### What changes were proposed in this pull request?
add missing headers and license

### Why are the changes needed?
Fix: apache#1267

### Does this PR introduce _any_ user-facing change?
N/A

### How was this patch tested?
N/A (no code change, only add missing license)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brandboat brandboat

Labels
good first issue Good for newcomers improvement Improvements on everything
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#1267] fix: Add missing headers and license brandboat/gravitino
5 participants
@justinmclean @jerryshao @brandboat @yuqi1129 @qqqttt123