Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug report] Property key gravitino.identifier should not be visible by users #1047

Closed
yuqi1129 opened this issue Dec 9, 2023 · 0 comments · Fixed by #1163
Closed

[Bug report] Property key gravitino.identifier should not be visible by users #1047

yuqi1129 opened this issue Dec 9, 2023 · 0 comments · Fixed by #1163
Assignees
@yuqi1129
Milestone
Gravitino 0.4.0

Comments

@yuqi1129
Copy link
Contributor

yuqi1129 commented Dec 9, 2023

Describe what's wrong

➜  [/Users/yuqi/project/graviton/docs] git:(main) ✗ curl -X GET -H "Accept: application/vnd.gravitino.v1+json" -H "Content-Type: application/json"  http://localhost:8090/api/metalakes/metalake
{"code":0,"metalake":{"name":"metalake","comment":"This is a new metalake","properties":{"gravitino.identifier":"gravitino.v1.uid2926922148829935947"},"audit":{"creator":"gravitino","createTime":"2023-12-09T07:57:28.778Z"}}}%

Error message and/or stacktrace

No response

How to reproduce

No response

Additional context

No response
@jerryshao jerryshao added this to the Gravitino 0.4.0 milestone Dec 14, 2023
This was referenced Dec 14, 2023
Closed
Merged
@mchades mchades assigned yuqi1129 and unassigned mchades Dec 18, 2023
jerryshao pushed a commit that referenced this issue Dec 18, 2023
@yuqi1129
[#1047] improvement(core): Fix the issue of StringIdentifier in metal…
9450e5c 
…ake property (#1163)

### What changes were proposed in this pull request?

Remove the `stringId` from metalake property map. 

### Why are the changes needed?

`gravitino.identifier` is generated internally and should not be visible
to users.

Fix: #1047 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

Existing UTs can cover it.
@github-actions github-actions bot mentioned this issue Dec 18, 2023
Merged
github-actions bot pushed a commit that referenced this issue Dec 18, 2023
@yuqi1129 @web-flow
[#1047] improvement(core): Fix the issue of StringIdentifier in metal…
4decff0 
…ake property (#1163)

### What changes were proposed in this pull request?

Remove the `stringId` from metalake property map. 

### Why are the changes needed?

`gravitino.identifier` is generated internally and should not be visible
to users.

Fix: #1047 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

Existing UTs can cover it.
jerryshao pushed a commit that referenced this issue Dec 18, 2023
@github-actions @yuqi1129
[#1047] improvement(core): Fix the issue of StringIdentifier in metal…
a55b708 
…ake property (#1188)

### What changes were proposed in this pull request?

Remove the `stringId` from metalake property map. 

### Why are the changes needed?

`gravitino.identifier` is generated internally and should not be visible
to users.

Fix: #1047 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

Existing UTs can cover it.

Co-authored-by: Qi Yu <yuqi@datastrato.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuqi1129 yuqi1129

Labels
None yet
Projects
None yet
Milestone
Gravitino 0.4.0
3 participants
@jerryshao @yuqi1129 @mchades