Skip to content

Conversation

@jamesfredley
Copy link
Contributor

@jamesfredley jamesfredley commented Jun 24, 2025

Also:

Back to Grails 7.0.0-SNAPSHOT
Update to Gradle 8.14.2

@jamesfredley jamesfredley self-assigned this Jun 24, 2025
@jamesfredley jamesfredley moved this to In Progress in Apache Grails Jun 24, 2025
@jamesfredley jamesfredley added this to the grails:7.0.0-RC1 milestone Jun 24, 2025
@jamesfredley jamesfredley requested a review from Copilot June 24, 2025 23:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the asset-pipeline plugin dependency from com.bertramlabs to cloud.wondrify across multiple build files while also reverting to Grails 7.0.0-SNAPSHOT and updating the Gradle version to 8.14.2.

  • Updated asset-pipeline IDs and runtime dependencies in various build scripts
  • Revised documentation links and workarounds to reflect the new dependency source
  • Modified wrapper scripts and configuration files to support Gradle 8.14.2 and Grails 7.0.0-SNAPSHOT

Reviewed Changes

Copilot reviewed 17 out of 19 changed files in this pull request and generated no comments.

Show a summary per file
File Description
plugin-ui/plugin/build.gradle Updated plugin ID and runtime dependency
plugin-ui/examples/simple/build.gradle Updated plugin ID and runtime dependency
plugin-ui/examples/extended/build.gradle Updated plugin ID and runtime dependency
plugin-ui/docs/src/docs/customization.adoc Updated documentation link for asset-pipeline
plugin-ldap/examples/*/build.gradle Updated plugin ID and runtime dependency in multiple LDAP examples
plugin-core/examples/functional-test-app/build.gradle Updated plugin ID and runtime dependency
plugin-cas/examples/spring-security-cas-test1/build.gradle Updated plugin ID and runtime dependency
gradlew.bat Updated command line arguments and CLASSPATH handling
gradlew Modified CLASSPATH assignment and jar execution approach
gradle/wrapper/gradle-wrapper.properties Updated Gradle distribution URL version
gradle/examples-config.gradle Updated workaround comment link
gradle.properties Updated Grails version from M4 to SNAPSHOT
buildSrc/build.gradle Updated dependency from com.bertramlabs to cloud.wondrify
.sdkmanrc Updated Gradle version
Comments suppressed due to low confidence (2)

gradlew.bat:73

  • Verify that setting an empty CLASSPATH alongside the use of the -jar option is fully supported across all target Windows environments, ensuring consistent wrapper behavior.
set CLASSPATH=

gradlew:117

  • Double-check that assigning CLASSPATH to an empty escaped string is intentional when switching to the -jar execution mode, and that it doesn't affect other parts of the script in different shell environments.
CLASSPATH="\\\"\\\""

@jamesfredley jamesfredley requested review from bkoehm and matrei June 24, 2025 23:52
@jamesfredley jamesfredley merged commit f2168ab into 7.0.x Jun 25, 2025
24 of 25 checks passed
@jamesfredley jamesfredley deleted the wondrify-groupid branch June 25, 2025 14:18
@github-project-automation github-project-automation bot moved this from In Progress to Done in Apache Grails Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants