[GOBBLIN-2090] delete deadline triggers in all hosts#3973
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3973 +/- ##
============================================
- Coverage 54.80% 47.19% -7.61%
- Complexity 1608 8103 +6495
============================================
Files 316 1553 +1237
Lines 11516 61489 +49973
Branches 1204 6969 +5765
============================================
+ Hits 6311 29019 +22708
- Misses 4629 29779 +25150
- Partials 576 2691 +2115 ☔ View full report in Codecov by Sentry. |
umustafi
reviewed
Jun 14, 2024
| public DagManagementDagActionStoreChangeMonitor(Config config, int numThreads, | ||
| FlowCatalog flowCatalog, Orchestrator orchestrator, DagManagementStateStore dagManagementStateStore, | ||
| boolean isMultiActiveSchedulerEnabled, DagManagement dagManagement) { | ||
| boolean isMultiActiveSchedulerEnabled, DagManagement dagManagement, DagActionReminderScheduler dagActionReminderScheduler) { |
Contributor
There was a problem hiding this comment.
do u need to make sure initialization order in guide works here?
Contributor
Author
There was a problem hiding this comment.
DagActionReminderScheduler only needs StdSchedulerFactory, which does not need any other dependency for initialization, so there should not be any circular dependency.
If creation of DagActionReminderScheduler were indirectly dependent on DagManagementDagActionStoreChangeMonitorFactory, that would have been a problem.
Comment on lines
+179
to
+186
| public static void mockDMSSCommonBehavior(DagManagementStateStore dagManagementStateStore) throws IOException, SpecNotFoundException { | ||
| doReturn(FlowSpec.builder().build()).when(dagManagementStateStore).getFlowSpec(any()); | ||
| doNothing().when(dagManagementStateStore).tryAcquireQuota(any()); | ||
| doReturn(true).when(dagManagementStateStore).releaseQuota(any()); | ||
| } | ||
|
|
||
| public static TopologySpec buildNaiveTopologySpec(String specUriInString) { | ||
| String specStoreDir = "/tmp/specStoreDir"; |
umustafi
approved these changes
Jun 17, 2024
arjun4084346
changed the title
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
JIRA
Description
i) It changes DagManagementDagActionStoreChangeMonitor and delete triggers whenever deadline enforcement dag actions are deleted.
ii) Removed EnforceJobStartDeadlineDagAction when a job/dag is cancelled, so that the job that never started (and hence able to clear EnforceJobStartDeadlineDagAction), can clean it now.
iii) removed unused enums CANCEL and RETRY in DagActionStore
iv) also fixes several unit tests and did refactoring
v) fixed codestyle changes suggested by intelliJ whatever came across during the work
Tests
DagManagementDagActionStoreChangeMonitorTest
Commits