Skip to content

[CH-320] Support space function #1054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zzcclp merged 2 commits into from
Apr 19, 2023
Merged

[CH-320] Support space function #1054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
30196f7
support sparce function
Feb 28, 2023
e045029
ci fix
KevinyhZou Apr 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions ...ends-clickhouse/src/test/scala/io/glutenproject/execution/GlutenClickHouseTPCHSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,6 +387,24 @@ class GlutenClickHouseTPCHSuite extends GlutenClickHouseTPCHAbstractSuite {
TestUtils.compareAnswers(result, expectedResult)
}

test("test 'function space'") {
val df = spark.sql(
"""
| select
| space(3),
| space(0),
| space(NULL),
| space(3/3.00f)
| from lineitem limit 1
|""".stripMargin
)
val result = df.collect()
assert(result(0).getString(0).equals(" "))
assert(result(0).getString(1).equals(""))
assert(result(0).getString(2) == null)
assert(result(0).getString(3).equals(" "))
}

test("test 'ISSUE https://github.com/Kyligence/ClickHouse/issues/225'") {
val df = spark.sql(
"""
Expand Down
2 changes: 2 additions & 0 deletions gluten-core/src/main/scala/io/glutenproject/expression/ExpressionMappings.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ object ExpressionMappings {
final val CONCAT_WS = "concat_ws"
final val REPEAT = "repeat"
final val TRANSLATE = "translate"
final val SPACE = "space"

// SparkSQL Math functions
final val ABS = "abs"
Expand Down Expand Up @@ -281,6 +282,7 @@ object ExpressionMappings {
Sig[ConcatWs](CONCAT_WS),
Sig[StringRepeat](REPEAT),
Sig[StringTranslate](TRANSLATE),
Sig[StringSpace](SPACE),
// SparkSQL Math functions
Sig[Abs](ABS),
Sig[Ceil](CEIL),
Expand Down