Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(kotlin): Add spotless ktfmt and enable explicit api mode for library code. #1912

Merged
merged 9 commits into from
Oct 26, 2024
Merged

build(kotlin): Add spotless ktfmt and enable explicit api mode for library code. #1912

merged 9 commits into from
Oct 26, 2024

Conversation

wywen
Copy link
Contributor

@wywen wywen commented Oct 26, 2024

What does this PR do?

This PR modifies the build to:

  1. add ktfmt - Since the fury java uses GOOGLE style, the fury kotlin will also use GOOGLE style. The version of ktfmt used is the highest compatible with the spotless maven plugin.
  2. explicit api mode
  3. parameterized kotlin version in pom.xml so it is easy to change in future
  4. Update README.md with build, format and testing instructions.

Related issues

#1896

Does this PR introduce any user-facing change?

None.

Benchmark

N/A

@wywen wywen requested a review from chaokunyang as a code owner October 26, 2024 14:15
chaokunyang
chaokunyang approved these changes Oct 26, 2024
View reviewed changes
Copy link
Collaborator

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks awesome!

@chaokunyang chaokunyang merged commit 86d1201 into apache:main Oct 26, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaokunyang chaokunyang chaokunyang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wywen @chaokunyang