Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix ci error #1691

Merged
merged 1 commit into from
Jun 18, 2024
Merged

ci: fix ci error #1691

merged 1 commit into from
Jun 18, 2024

Conversation

LiangliangSui
Copy link
Contributor

@LiangliangSui LiangliangSui commented Jun 18, 2024 •
edited
Loading

What does this PR do?

The current CI keeps failing.

Error:

  A module that was compiled using NumPy 1.x cannot be run in
  NumPy 2.0.0 as it may crash. To support both 1.x and 2.x
  versions of NumPy, modules must be compiled with NumPy 2.0.
  Some module may need to rebuild instead e.g. with 'pybind11>=2.12'.

numpy was updated to 2.0.0 on Jun 16, 2024, which caused compatibility issues with CI, so numpy<2.0.0 was set.

image

Related issues

Does this PR introduce any user-facing change?

  • Does this PR introduce any public API change?
  • Does this PR introduce any binary protocol compatibility change?

Benchmark

@LiangliangSui
ci: fix ci error
41b7d0a 
Signed-off-by: LiangliangSui <coolsui.coding@gmail.com>
@LiangliangSui LiangliangSui mentioned this pull request Jun 18, 2024
Merged
2 tasks
chaokunyang
chaokunyang approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaokunyang chaokunyang merged commit a0dd77e into apache:main Jun 18, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaokunyang chaokunyang chaokunyang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LiangliangSui @chaokunyang