Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(java): meta string strip last char && check empty encoded string #1587

Merged
merged 2 commits into from
Apr 27, 2024

Conversation

qingoba
Copy link
Contributor

@qingoba qingoba commented Apr 27, 2024

What does this PR do?

Fix two bugs:

  • fix method MetaString.stripLastChar() logical error
  • add empty encoded bytes check in MetaStringDecoder.decode()

Related issues

Does this PR introduce any user-facing change?

  • [No] Does this PR introduce any public API change?
  • [No] Does this PR introduce any binary protocol compatibility change?

@qingoba qingoba changed the title fix(java): meta string strip last char &$ check empty encoded string fix(java): meta string strip last char && check empty encoded string Apr 27, 2024
Copy link
Collaborator

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks very much @qingoba

@chaokunyang
Copy link
Collaborator

Code lint error:
image

Could you use mvn spotless:apply to format java code?

@chaokunyang chaokunyang merged commit 6ad2ca5 into apache:main Apr 27, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants