Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C++] Split util.h to bit_util.h and time_util.h #1171

Merged
merged 3 commits into from
Nov 29, 2023

Conversation

PragmaTwice
Copy link
Member

@PragmaTwice PragmaTwice commented Nov 29, 2023

What do these changes do?

util/util.h is splitted to util/bit_util.h and util/time_util.h.
namespace BitUtil is renamed to util.

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

Copy link
Collaborator

@chaokunyang chaokunyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chaokunyang chaokunyang merged commit abea783 into apache:main Nov 29, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants