-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Python] Support python3.11/12 #1064
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compile error: In file included from bazel-out/darwin-opt/bin/external/local_config_pyarrow/include/arrow/array/data.h:26:
bazel-out/darwin-opt/bin/external/local_config_pyarrow/include/arrow/buffer.h:163:39: error: expected '(' for function-style cast or type construction
static_assert(std::is_trivial_v<T>,
~~~~~~~~~~~~~~~~~~~~^
bazel-out/darwin-opt/bin/external/local_config_pyarrow/include/arrow/buffer.h:458:9: error: no matching constructor for initialization of 'arrow::Buffer'
: Buffer(data, size, std::move(mm)) {
^ ~~~~~~~~~~~~~~~~~~~~~~~~~
bazel-out/darwin-opt/bin/external/local_config_pyarrow/include/arrow/buffer.h:89:3: note: candidate constructor not viable: no known conversion from 'uint8_t *' (aka 'unsigned char *') to 'uintptr_t' (aka 'unsigned long') for 1st argument; dereference the argument with *
Buffer(uintptr_t address, int64_t size, std::shared_ptr<MemoryManager> mm, |
chaokunyang
force-pushed
the
support_python3.11
branch
from
November 21, 2023 05:06
24b4fd6
to
11a949a
Compare
This has been fixed in #1093, thanks @PragmaTwice |
chaokunyang
force-pushed
the
support_python3.11
branch
from
November 21, 2023 08:50
9e15729
to
135af4e
Compare
chaokunyang
force-pushed
the
support_python3.11
branch
3 times, most recently
from
November 21, 2023 11:50
f8f7598
to
100e509
Compare
chaokunyang
force-pushed
the
support_python3.11
branch
from
November 21, 2023 11:52
100e509
to
5804852
Compare
LGTM |
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Related issue number
Closes #1118
Check code requirements