Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Support python3.11/12 #1064

Merged
merged 17 commits into from
Nov 21, 2023
Merged

Conversation

chaokunyang
Copy link
Collaborator

@chaokunyang chaokunyang commented Nov 3, 2023

What do these changes do?

  • Support python3.11/12
  • Drop python 3.6 support
  • Use pyarrow==14.0.0
  • Use arrow14 for java
  • Use pyarrow==12 for python3.7
  • Use bazel 6.3.2
  • Remove D_GLIBCXX_USE_CXX11_ABI option since arrow removed it for compilation

Related issue number

Closes #1118

Check code requirements

  • tests added / passed (if needed)
  • Ensure all linting tests pass, see here for how to run them

@chaokunyang chaokunyang marked this pull request as draft November 3, 2023 11:46
@chaokunyang
Copy link
Collaborator Author

Compile error:

In file included from bazel-out/darwin-opt/bin/external/local_config_pyarrow/include/arrow/array/data.h:26:
bazel-out/darwin-opt/bin/external/local_config_pyarrow/include/arrow/buffer.h:163:39: error: expected '(' for function-style cast or type construction
    static_assert(std::is_trivial_v<T>,
                  ~~~~~~~~~~~~~~~~~~~~^
bazel-out/darwin-opt/bin/external/local_config_pyarrow/include/arrow/buffer.h:458:9: error: no matching constructor for initialization of 'arrow::Buffer'
      : Buffer(data, size, std::move(mm)) {
        ^      ~~~~~~~~~~~~~~~~~~~~~~~~~
bazel-out/darwin-opt/bin/external/local_config_pyarrow/include/arrow/buffer.h:89:3: note: candidate constructor not viable: no known conversion from 'uint8_t *' (aka 'unsigned char *') to 'uintptr_t' (aka 'unsigned long') for 1st argument; dereference the argument with *
  Buffer(uintptr_t address, int64_t size, std::shared_ptr<MemoryManager> mm,

@chaokunyang chaokunyang marked this pull request as ready for review November 21, 2023 05:06
@chaokunyang
Copy link
Collaborator Author

chaokunyang commented Nov 21, 2023

Compile error:

In file included from bazel-out/darwin-opt/bin/external/local_config_pyarrow/include/arrow/array/data.h:26:
bazel-out/darwin-opt/bin/external/local_config_pyarrow/include/arrow/buffer.h:163:39: error: expected '(' for function-style cast or type construction
    static_assert(std::is_trivial_v<T>,
                  ~~~~~~~~~~~~~~~~~~~~^
bazel-out/darwin-opt/bin/external/local_config_pyarrow/include/arrow/buffer.h:458:9: error: no matching constructor for initialization of 'arrow::Buffer'
      : Buffer(data, size, std::move(mm)) {
        ^      ~~~~~~~~~~~~~~~~~~~~~~~~~
bazel-out/darwin-opt/bin/external/local_config_pyarrow/include/arrow/buffer.h:89:3: note: candidate constructor not viable: no known conversion from 'uint8_t *' (aka 'unsigned char *') to 'uintptr_t' (aka 'unsigned long') for 1st argument; dereference the argument with *
  Buffer(uintptr_t address, int64_t size, std::shared_ptr<MemoryManager> mm,

This has been fixed in #1093, thanks @PragmaTwice

@chaokunyang chaokunyang force-pushed the support_python3.11 branch 3 times, most recently from f8f7598 to 100e509 Compare November 21, 2023 11:50
@theweipeng
Copy link
Member

LGTM

@theweipeng theweipeng merged commit c806cba into apache:main Nov 21, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Python] Drop python3.6 support
2 participants