Closed
Conversation
…to detect the encoding of a string. Additionally, we have submitted a PR to Node.js for detecting string encoding. If this PR is merged, we will be able to achieve good performance without this flag.
Collaborator
|
@theweipeng Should we still keep OK，I'll turn this into a draft |
Member
Author
|
It will be a long time before that PR committed in node repo be released. And hps module has far more performance than the way provided by that PR. So I will close this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removed HPS because we can now use
--expose_externalize_stringto detect the encoding of a string.Additionally, we have submitted a PR (nodejs/node#56147) to Node.js for detecting string encoding. If this PR is merged, we will be able to achieve good performance without this flag.
Related issues
#2000