[rust] Wire batch statistics into the log batch write and read paths - #4074
Open
leekeiabstraction wants to merge 1 commit into
Open
[rust] Wire batch statistics into the log batch write and read paths#4074leekeiabstraction wants to merge 1 commit into
leekeiabstraction wants to merge 1 commit into
Conversation
leekeiabstraction
force-pushed
the
rust-batch-stats-wiring
branch
10 times, most recently
from
August 23, 2026 16:19
e33bb99 to
c09cb91
Compare
Tables with 'table.statistics.columns' set now produce V1 batches carrying serialized statistics, matching Java's MemoryLogRecordsArrowBuilder. The reader now locates the records data per the batch's magic, fixing the misparsing of V1 batches that Java clients and the server's projection path already produce.
leekeiabstraction
force-pushed
the
rust-batch-stats-wiring
branch
from
August 23, 2026 17:25
c09cb91 to
48718e9
Compare
Contributor
Author
|
@fresh-borzoni @platinumhamburg @charlesdong1991 Appreciate a review here 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
table.statistics.columnsset emit V1 batches carrying the serialized statistics between the header and the records data, mirroring Java'sMemoryLogRecordsArrowBuilder. A serialization failure degrades to an empty statistics section rather than failing the batch.arrow.rsinto a newlog_record_batch.rs, separating the Fluss wire format from Arrow IPC concerns. The Arrow builder's long argument lists collapsed into anArrowBatchConfigstruct.Test Plan
fluss-common/src/test/resources/encoding/statistics_block.hex) pins the statistics block byte-for-byte across all supported types, nulls, both decimal widths, both timestamp precisions, and float NaN/signed-zero ordering (bounds follow Java'sFloat.comparesemantics, not Arrow's IEEE totalOrder). A new Java test generates it, asserts it and parses it back verifying the decoded bounds; the Rust test reads the same file.cargo test -p fluss-rs --libpasses 707 tests; clippy and fmt are clean; the end-to-end integration test is left to [rust] Filter pushdown integration test #3845.🤖 AI-assisted changes - reviewed by human developer