Support shared RocksDB rate limiter in Fluss #2178
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
platinumhamburg
force-pushed
the
ratelimiter
branch
2 times, most recently
from
a153b67 to
4aee7df
Compare
...mon/src/main/java/org/apache/fluss/flink/procedure/SetSharedRocksDBRateLimiterProcedure.java
Outdated
Show resolved
Hide resolved
swuferhong
reviewed
Dec 16, 2025
Contributor
swuferhong
left a comment
swuferhong
left a comment
There was a problem hiding this comment.
Thanks for your contributions. I left some comments.
...mon/src/main/java/org/apache/fluss/flink/procedure/SetSharedRocksDBRateLimiterProcedure.java
Outdated
Show resolved
Hide resolved
...mon/src/main/java/org/apache/fluss/flink/procedure/GetSharedRocksDBRateLimiterProcedure.java
Outdated
Show resolved
Hide resolved
platinumhamburg
force-pushed
the
ratelimiter
branch
from
4aee7df to
d44ea65
Compare
platinumhamburg
force-pushed
the
ratelimiter
branch
from
6382ed3 to
df9a263
Compare
swuferhong
reviewed
Dec 18, 2025
Contributor
swuferhong
left a comment
swuferhong
left a comment
There was a problem hiding this comment.
LGTM. Left one minor comment.
| * | ||
| * -- Delete a configuration (reset to default) | ||
| * CALL sys.set_cluster_config('kv.shared-rate-limiter.bytes-per-sec', NULL); | ||
| * CALL sys.set_cluster_config('kv.shared-rate-limiter.bytes-per-sec', ''); |
Contributor
There was a problem hiding this comment.
Maybe set_cluster_config and delete_cluster_config can be divided into different procedures?
| } catch (Exception e) { | ||
| // Ignore cleanup errors to avoid masking test failures | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Can these be moved into test cases related to set cluster configuration? It feels a bit odd to place them in afterEach？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Linked issue: close #2177
Brief change log
Tests
API and Format
Documentation